[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e86fec57-de90-4663-9a32-7c50a97cde67@rock-chips.com>
Date: Fri, 16 May 2025 15:44:14 +0800
From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
To: Heiko Stübner <heiko@...ech.de>,
Sandy Huang <hjc@...k-chips.com>, Andy Yan <andy.yan@...k-chips.com>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Chaoyi Chen <kernel@...kyi.com>
Cc: Dragan Simic <dsimic@...jaro.org>, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dt-bindings: display: rockchip: Convert
cdn-dp-rockchip.txt to yaml
Hi Heiko,
On 2025/5/15 21:00, Heiko Stübner wrote:
> Hi,
>
> Am Dienstag, 13. Mai 2025, 03:19:04 Mitteleuropäische Sommerzeit schrieb Chaoyi Chen:
>> From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Input of the CDN DP
>> + properties:
>> + endpoint@0:
>> + description: Connection to the VOPB
>> + endpoint@1:
>> + description: Connection to the VOPL
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: Output of the CDN DP
>> +
>> + required:
>> + - port@0
>> + - port@1
> you're adding the 2nd port (port@1) as output port, which has not been
> part of the old binding. I think this warrants an explanation in the
> commit message on what it is meant to contain.
This is mainly to keep consistent with the binding style of other
display interfaces, which all have an Input (port@0) and Output (port@1).
This change has no effect on the driver. I will explain this in v4.
Powered by blists - more mailing lists