linux-kernel - Re: [PATCH] mux: mmio: Fix missing CONFIG_REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3172aba1-77f8-46a7-a967-14fae37f66ea@linaro.org>
Date: Fri, 16 May 2025 10:58:38 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Peter Rosin <peda@...ntia.se>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Andrew Davis <afd@...com>, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>
Cc: kernel test robot <lkp@...el.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Samuel Holland <samuel@...lland.org>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] mux: mmio: Fix missing CONFIG_REGMAP_MMIO

On 16/05/2025 10:26, Krzysztof Kozlowski wrote:
> On 16/05/2025 10:16, Krzysztof Kozlowski wrote:
>>
>> On Thu, 15 May 2025 16:05:56 +0200, Krzysztof Kozlowski wrote:
>>> MMIO mux uses now regmap_init_mmio(), so one way or another
>>> CONFIG_REGMAP_MMIO should be enabled, because there are no stubs for
>>> !REGMAP_MMIO case:
>>>
>>>   ERROR: modpost: "__regmap_init_mmio_clk" [drivers/mux/mux-mmio.ko] undefined!
>>>
>>> REGMAP_MMIO should be, because it is a non-visible symbol, but this
>>> causes a circular dependency:
>>>
>>> [...]
>>
>> Applied, thanks!
>>
>> [1/1] mux: mmio: Fix missing CONFIG_REGMAP_MMIO
>>       https://git.kernel.org/krzk/linux/c/39bff565b40d26cc51f6e85b3b224c86a563367e
>>
> And dropped. More recursive dependencies are detected, so my fix here is
> incomplete.
> 
> error: recursive dependency detected!
> 	symbol REGMAP default is visible depending on REGMAP_MMIO
> 	symbol REGMAP_MMIO is selected by MUX_MMIO
> 	symbol MUX_MMIO depends on MULTIPLEXER
> 	symbol MULTIPLEXER is selected by MDIO_BUS_MUX_MULTIPLEXER
> 	symbol MDIO_BUS_MUX_MULTIPLEXER depends on MDIO_BUS
> 	symbol MDIO_BUS is selected by REGMAP
> 
> https://krzk.eu/#/builders/43/builds/4855
> 
> That's a mess, I need work on this a bit more.

My branch fails with above error because I do not have Heiner's commit
a3e1c0ad8357 ("net: phy: factor out provider part from mdio_bus.c").
Will it reach current RC (rc7) at some point? I could merge the tag to
my next branch to solve it.

Best regards,
Krzysztof