linux-kernel - Re: [PATCH v2 1/3] dt-bindings: clock: ti: Convert autoidle binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <174738938517.2667160.10906175729020548648.robh@kernel.org>
Date: Fri, 16 May 2025 04:56:25 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Sukrut Bellary <sbellary@...libre.com>
Cc: Kevin Hilman <khilman@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
 linux-clk@...r.kernel.org, Tero Kristo <kristo@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, Andreas Kemnade <andreas@...nade.info>, 
 devicetree@...r.kernel.org, Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: ti: Convert autoidle
 binding to yaml


On Fri, 16 May 2025 01:16:10 -0700, Sukrut Bellary wrote:
> Autoidle clock is not an individual clock; it is always a derivate of some
> basic clock like a gate, divider, or fixed-factor. This binding will be
> referred in ti,divider-clock.yaml, and ti,fixed-factor-clock.yaml.
> 
> As all clocks don't support the autoidle feature e.g.,
> in DRA77xx/AM57xx[1], dpll_abe_x2* and dpll_per_x2 don't have
> autoidle, remove required properties from the binding.
> 
> Add the creator of the original binding as a maintainer.
> 
> [1] https://www.ti.com/lit/ug/spruhz6l/spruhz6l.pdf
> 
> Signed-off-by: Sukrut Bellary <sbellary@...libre.com>
> ---
>  .../devicetree/bindings/clock/ti/autoidle.txt | 37 -------------------
>  .../bindings/clock/ti/ti,autoidle.yaml        | 34 +++++++++++++++++
>  2 files changed, 34 insertions(+), 37 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/clock/ti/autoidle.txt
>  create mode 100644 Documentation/devicetree/bindings/clock/ti/ti,autoidle.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/clock/ti/fixed-factor-clock.txt references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Warning: Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml references a file that doesn't exist: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Documentation/devicetree/bindings/clock/ti/fixed-factor-clock.txt: Documentation/devicetree/bindings/clock/ti/autoidle.txt
Documentation/devicetree/bindings/clock/ti/ti,divider-clock.yaml: Documentation/devicetree/bindings/clock/ti/autoidle.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250516081612.767559-2-sbellary@baylibre.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.