linux-kernel - Re: [PATCH RFC 3/3] ASoC: generic: add more sample DTSIs for audio-graph-card2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734d5tixb.wl-kuninori.morimoto.gx@renesas.com>
Date: Fri, 16 May 2025 10:59:12 +0900
From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To: "Laurentiu Mihalcea" <laurentiumihalcea111@...il.com>
Cc: Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org
Subject: Re: [PATCH RFC 3/3] ASoC: generic: add more sample DTSIs for audio-graph-card2


Hi Laurentiu

Thank you for caring sample dtsi

> Add some more audio-graph-card2 sample DTSIs meant to aid in testing
> the driver's capability to parse explicitly disabled links. To conclude
> that the feature works correctly, all audio-graph-card2 samples need to
> work as expected. This includes the custom ones:
> 
> 	1) audio-graph-card2-custom-sample1.dtsi
> 	2) audio-graph-card2-custom-sample2.dtsi
> 
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> ---
>  .../generic/audio-graph-card2-sample1.dtsi    | 278 ++++++
>  .../generic/audio-graph-card2-sample2.dtsi    | 878 ++++++++++++++++++
>  .../generic/audio-graph-card2-sample3.dtsi    | 486 ++++++++++

This is not a "audio graph card2 sample", but a "disable_of_route_checks"
sample, I think.

I wonder can we re-use existing sample dtsi, like below ??

	/*
	 * Sample of disable_of_route_checks
	 */
	#include "..../audio-graph-card2-custom-sample1.dtsi"
	
	&audio-graph-card2-custom-sample-1 {
		force_detect_xxx;
	};

	&test_codec_1 {
		status = "disabled";
	};


Indeed current existing sample is using single Codec or CPU which have
many DAIs. So can't enable/disable each detail DAIs, like your patch did.
If it was not good for you, may be we can separate ?

	test_codec_1 {
		...
-		port@X { ... };
-		port@Y { ... };
	}

	test_codec_2 {
		...
+		port@X { ... };
+		port@Y { ... };
	}

&test_codec_2 {
	status = "disabled";
};


Thank you for your help !!

Best regards
---
Kuninori Morimoto