linux-kernel - Re: [PATCH RESEND] drm/xe/display: Add check for alloc_ordered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a57cwxtb.fsf@intel.com>
Date: Fri, 16 May 2025 15:21:36 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Haoxiang Li <haoxiang_li2024@....com>, thomas.hellstrom@...ux.intel.com,
 airlied@...il.com, simona@...ll.ch, maarten.lankhorst@...ux.intel.com
Cc: intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, Haoxiang Li
 <haoxiang_li2024@....com>, stable@...r.kernel.org
Subject: Re: [PATCH RESEND] drm/xe/display: Add check for
 alloc_ordered_workqueue()

On Thu, 24 Apr 2025, Haoxiang Li <haoxiang_li2024@....com> wrote:
> Add check for the return value of alloc_ordered_workqueue()
> in xe_display_create() to catch potential exception.
>
> Fixes: 44e694958b95 ("drm/xe/display: Implement display support")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>

This patch seems to have been neglected, apologies.

I've rebased it and included it as part of a bigger series [1].

Thanks for the patch.

BR,
Jani.


[1] https://lore.kernel.org/r/cover.1747397638.git.jani.nikula@intel.com

> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 0b0aca7a25af..18062cfb265f 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -104,6 +104,8 @@ int xe_display_create(struct xe_device *xe)
>  	spin_lock_init(&xe->display.fb_tracking.lock);
>  
>  	xe->display.hotplug.dp_wq = alloc_ordered_workqueue("xe-dp", 0);
> +	if (!xe->display.hotplug.dp_wq)
> +		return -ENOMEM;
>  
>  	return drmm_add_action_or_reset(&xe->drm, display_destroy, NULL);
>  }

-- 
Jani Nikula, Intel