Message-ID: <20250516130950.GA530183@ziepe.ca>
Date: Fri, 16 May 2025 10:09:50 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Rick P Edgecombe <rick.p.edgecombe@...el.com>,
	Vishal Annapurve <vannapurve@...gle.com>,
	"palmer@...belt.com" <palmer@...belt.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	Jun Miao <jun.miao@...el.com>,
	"nsaenz@...zon.es" <nsaenz@...zon.es>,
	"pdurrant@...zon.co.uk" <pdurrant@...zon.co.uk>,
	"vbabka@...e.cz" <vbabka@...e.cz>,
	"peterx@...hat.com" <peterx@...hat.com>,
	"x86@...nel.org" <x86@...nel.org>,
	"tabba@...gle.com" <tabba@...gle.com>,
	"keirf@...gle.com" <keirf@...gle.com>,
	"quic_svaddagi@...cinc.com" <quic_svaddagi@...cinc.com>,
	"amoorthy@...gle.com" <amoorthy@...gle.com>,
	"pvorel@...e.cz" <pvorel@...e.cz>,
	"quic_eberman@...cinc.com" <quic_eberman@...cinc.com>,
	"mail@...iej.szmigiero.name" <mail@...iej.szmigiero.name>,
	"vkuznets@...hat.com" <vkuznets@...hat.com>,
	"anthony.yznaga@...cle.com" <anthony.yznaga@...cle.com>,
	Wei W Wang <wei.w.wang@...el.com>, "jack@...e.cz" <jack@...e.cz>,
	Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>,
	Yan Y Zhao <yan.y.zhao@...el.com>,
	Dave Hansen <dave.hansen@...el.com>,
	"ajones@...tanamicro.com" <ajones@...tanamicro.com>,
	"paul.walmsley@...ive.com" <paul.walmsley@...ive.com>,
	"quic_mnalajal@...cinc.com" <quic_mnalajal@...cinc.com>,
	"aik@....com" <aik@....com>,
	"usama.arif@...edance.com" <usama.arif@...edance.com>,
	"willy@...radead.org" <willy@...radead.org>,
	"rppt@...nel.org" <rppt@...nel.org>,
	"bfoster@...hat.com" <bfoster@...hat.com>,
	"quic_cvanscha@...cinc.com" <quic_cvanscha@...cinc.com>,
	Fan Du <fan.du@...el.com>, "fvdl@...gle.com" <fvdl@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"thomas.lendacky@....com" <thomas.lendacky@....com>,
	"mic@...ikod.net" <mic@...ikod.net>,
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"steven.price@....com" <steven.price@....com>,
	"muchun.song@...ux.dev" <muchun.song@...ux.dev>,
	"binbin.wu@...ux.intel.com" <binbin.wu@...ux.intel.com>,
	Zhiquan1 Li <zhiquan1.li@...el.com>,
	"rientjes@...gle.com" <rientjes@...gle.com>,
	"mpe@...erman.id.au" <mpe@...erman.id.au>,
	Erdem Aktas <erdemaktas@...gle.com>,
	"david@...hat.com" <david@...hat.com>,
	"hughd@...gle.com" <hughd@...gle.com>,
	Haibo1 Xu <haibo1.xu@...el.com>,
	"jhubbard@...dia.com" <jhubbard@...dia.com>,
	"anup@...infault.org" <anup@...infault.org>,
	"maz@...nel.org" <maz@...nel.org>,
	Isaku Yamahata <isaku.yamahata@...el.com>,
	"jthoughton@...gle.com" <jthoughton@...gle.com>,
	"steven.sistare@...cle.com" <steven.sistare@...cle.com>,
	"jarkko@...nel.org" <jarkko@...nel.org>,
	"quic_pheragu@...cinc.com" <quic_pheragu@...cinc.com>,
	Kirill Shutemov <kirill.shutemov@...el.com>,
	"chenhuacai@...nel.org" <chenhuacai@...nel.org>,
	Kai Huang <kai.huang@...el.com>,
	"shuah@...nel.org" <shuah@...nel.org>,
	"dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
	"pankaj.gupta@....com" <pankaj.gupta@....com>,
	Chao Peng <chao.p.peng@...el.com>,
	"nikunj@....com" <nikunj@....com>, Alexander Graf <graf@...zon.com>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>,
	"yuzenghui@...wei.com" <yuzenghui@...wei.com>,
	"jroedel@...e.de" <jroedel@...e.de>,
	"suzuki.poulose@....com" <suzuki.poulose@....com>,
	"jgowans@...zon.com" <jgowans@...zon.com>,
	Yilun Xu <yilun.xu@...el.com>,
	"liam.merwick@...cle.com" <liam.merwick@...cle.com>,
	"michael.roth@....com" <michael.roth@....com>,
	"quic_tsoni@...cinc.com" <quic_tsoni@...cinc.com>,
	"richard.weiyang@...il.com" <richard.weiyang@...il.com>,
	Ira Weiny <ira.weiny@...el.com>,
	"aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
	Xiaoyao Li <xiaoyao.li@...el.com>,
	"qperret@...gle.com" <qperret@...gle.com>,
	"kent.overstreet@...ux.dev" <kent.overstreet@...ux.dev>,
	"dmatlack@...gle.com" <dmatlack@...gle.com>,
	"james.morse@....com" <james.morse@....com>,
	"brauner@...nel.org" <brauner@...nel.org>,
	"roypat@...zon.co.uk" <roypat@...zon.co.uk>,
	"ackerleytng@...gle.com" <ackerleytng@...gle.com>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"pgonda@...gle.com" <pgonda@...gle.com>,
	"quic_pderrin@...cinc.com" <quic_pderrin@...cinc.com>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"will@...nel.org" <will@...nel.org>,
	"hch@...radead.org" <hch@...radead.org>
Subject: Re: [RFC PATCH v2 00/51] 1G page support for guest_memfd

On Thu, May 15, 2025 at 05:57:57PM -0700, Sean Christopherson wrote:

> You're conflating two different things.  guest_memfd allocating and managing
> 1GiB physical pages, and KVM mapping memory into the guest at 1GiB/2MiB
> granularity.  Allocating memory in 1GiB chunks is useful even if KVM can only
> map memory into the guest using 4KiB pages.

Even if KVM is limited to 4K the IOMMU might not be - alot of these
workloads have a heavy IO component and we need the iommu to perform
well too.

Frankly, I don't think there should be objection to making memory more
contiguous. There is alot of data that this always brings wins
somewhere for someone.

> The longer term goal of guest_memfd is to make it suitable for backing all VMs,
> hence Vishal's "Non-CoCo VMs" comment.  Yes, some of this is useful for TDX, but
> we (and others) want to use guest_memfd for far more than just CoCo VMs.  And
> for non-CoCo VMs, 1GiB hugepages are mandatory for various workloads.

Yes, even from an iommu perspective with 2D translation we need to
have the 1G pages from the S2 resident in the IOTLB or performance
falls off a cliff.

Jason

Powered by blists - more mailing lists