linux-kernel - Re: [PATCH][next] apparmor: Fix incorrect profile->signal range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <68375b67-3930-4f54-8a66-e0b071a90110@canonical.com>
Date: Sat, 17 May 2025 01:44:13 -0700
From: John Johansen <john.johansen@...onical.com>
To: Ryan Lee <ryan.lee@...onical.com>, Colin Ian King <colin.i.king@...il.com>
Cc: Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
 "Serge E . Hallyn" <serge@...lyn.com>, apparmor@...ts.ubuntu.com,
 linux-security-module@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] apparmor: Fix incorrect profile->signal range check

On 5/6/25 10:07, Ryan Lee wrote:
> On Tue, May 6, 2025 at 10:04 AM Colin Ian King <colin.i.king@...il.com> wrote:
>>
>> The check on profile->signal is always false, the value can never be
>> less than 1 *and* greater than MAXMAPPED_SIG. Fix this by replacing
>> the logical operator && with ||.
>>
>> Fixes: 84c455decf27 ("apparmor: add support for profiles to define the kill signal")
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>> ---
>>   security/apparmor/policy_unpack.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/security/apparmor/policy_unpack.c b/security/apparmor/policy_unpack.c
>> index 73139189df0f..e643514a3d92 100644
>> --- a/security/apparmor/policy_unpack.c
>> +++ b/security/apparmor/policy_unpack.c
>> @@ -919,7 +919,7 @@ static struct aa_profile *unpack_profile(struct aa_ext *e, char **ns_name)
>>
>>          /* optional */
>>          (void) aa_unpack_u32(e, &profile->signal, "kill");
>> -       if (profile->signal < 1 && profile->signal > MAXMAPPED_SIG) {
>> +       if (profile->signal < 1 || profile->signal > MAXMAPPED_SIG) {
>>                  info = "profile kill.signal invalid value";
>>                  goto fail;
>>          }
>> --
>> 2.49.0
> Reviewed-by: Ryan Lee <ryan.lee@...onical.com>
> 

Acked-by: John Johansen <john.johansen@...onical.com>

I have pulled this into my tree