linux-kernel - Re: [PATCH v4 5/7] drm/panthor: Implement the counter sampler and sample handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505171601.i0qhMG1O-lkp@intel.com>
Date: Sat, 17 May 2025 16:56:33 +0800
From: kernel test robot <lkp@...el.com>
To: Lukas Zapolskas <lukas.zapolskas@....com>,
	Boris Brezillon <bbrezillon@...nel.org>,
	Steven Price <steven.price@....com>,
	Liviu Dudau <liviu.dudau@....com>,
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
	Maxime Ripard <mripard@...nel.org>,
	Thomas Zimmermann <tzimmermann@...e.de>,
	David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Adrián Larumbe <adrian.larumbe@...labora.com>,
	Lukas Zapolskas <lukas.zapolskas@....com>
Subject: Re: [PATCH v4 5/7] drm/panthor: Implement the counter sampler and
 sample handling

Hi Lukas,

kernel test robot noticed the following build errors:

[auto build test ERROR on 96c85e428ebaeacd2c640eba075479ab92072ccd]

url:    https://github.com/intel-lab-lkp/linux/commits/Lukas-Zapolskas/drm-panthor-Add-performance-counter-uAPI/20250517-000257
base:   96c85e428ebaeacd2c640eba075479ab92072ccd
patch link:    https://lore.kernel.org/r/7005fb2eba3abbb2ee95282d117f70c8a7c8555f.1747148172.git.lukas.zapolskas%40arm.com
patch subject: [PATCH v4 5/7] drm/panthor: Implement the counter sampler and sample handling
config: i386-buildonly-randconfig-002-20250517 (https://download.01.org/0day-ci/archive/20250517/202505171601.i0qhMG1O-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250517/202505171601.i0qhMG1O-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505171601.i0qhMG1O-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/panthor/panthor_perf.c:381:8: error: redefinition of 'panthor_perf_counter_block'
     381 | struct panthor_perf_counter_block {
         |        ^
   drivers/gpu/drm/panthor/panthor_perf.c:126:8: note: previous definition is here
     126 | struct panthor_perf_counter_block {
         |        ^
>> drivers/gpu/drm/panthor/panthor_perf.c:651:15: error: redefinition of 'session_get_user_sample_size'
     651 | static size_t session_get_user_sample_size(const struct drm_panthor_perf_info *const info)
         |               ^
   drivers/gpu/drm/panthor/panthor_perf.c:391:15: note: previous definition is here
     391 | static size_t session_get_user_sample_size(const struct drm_panthor_perf_info *const info)
         |               ^
>> drivers/gpu/drm/panthor/panthor_perf.c:1038:19: error: incompatible pointer types passing '__u64 (*)[2]' (aka 'unsigned long long (*)[2]') to parameter of type 'u64 *' (aka 'unsigned long long *') [-Werror,-Wincompatible-pointer-types]
    1038 |                 bitmap_to_arr64(&blk->header.enable_mask, blk_em, PANTHOR_PERF_EM_BITS);
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/bitmap.h:313:27: note: passing argument to parameter 'buf' here
     313 | void bitmap_to_arr64(u64 *buf, const unsigned long *bitmap, unsigned int nbits);
         |                           ^
   3 errors generated.


vim +/session_get_user_sample_size +651 drivers/gpu/drm/panthor/panthor_perf.c

   650	
 > 651	static size_t session_get_user_sample_size(const struct drm_panthor_perf_info *const info)
   652	{
   653		const size_t block_size = get_annotated_block_size(info->counters_per_block);
   654		const size_t block_nr = info->cshw_blocks + info->fw_blocks +
   655			info->tiler_blocks + info->memsys_blocks + info->shader_blocks;
   656	
   657		return sizeof(struct drm_panthor_perf_sample_header) + (block_size * block_nr);
   658	}
   659	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki