linux-kernel - Re: [PATCH] kunit: tool: add test counts to JSON output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSkNofHFvq2QxrT5tKV+9Z13AnYu+xvRr0f0Ae_hg6i4_w@mail.gmail.com>
Date: Sat, 17 May 2025 17:42:00 +0800
From: David Gow <davidgow@...gle.com>
To: Rae Moar <rmoar@...gle.com>
Cc: brendan.higgins@...ux.dev, skhan@...uxfoundation.org, dlatypov@...gle.com, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] kunit: tool: add test counts to JSON output

On Sat, 17 May 2025 at 04:17, Rae Moar <rmoar@...gle.com> wrote:
>
> Add the test counts to the JSON output from kunit.py. For example:
>
> ...
> "git_branch": "kselftest",
> "misc":
> {
>     "tests": 2,
>     "passed": 1.
>     "failed": 1,
>     "crashed": 0,
>     "skipped": 0,
>     "errors": 0,
> }
> ...
>
> To output the JSON using the following command:
> ./tools/testing/kunit/kunit.py run example --json
>
> This has been requested by KUnit users. The counts are in a "misc"
> field because the JSON output needs to be compliant with the KCIDB
> submission guide. There are no counts fields but there is a "misc" field
> in the guide.
>
> Signed-off-by: Rae Moar <rmoar@...gle.com>
> ---

Thanks! It's very nice to see `"failed": 0`!

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  tools/testing/kunit/kunit_json.py | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/tools/testing/kunit/kunit_json.py b/tools/testing/kunit/kunit_json.py
> index 10ff65689dd8..80fa4e354a17 100644
> --- a/tools/testing/kunit/kunit_json.py
> +++ b/tools/testing/kunit/kunit_json.py
> @@ -39,10 +39,20 @@ def _get_group_json(test: Test, common_fields: JsonObj) -> JsonObj:
>                 status = _status_map.get(subtest.status, "FAIL")
>                 test_cases.append({"name": subtest.name, "status": status})
>
> +       test_counts = test.counts
> +       counts_json = {
> +               "tests": test_counts.total(),
> +               "passed": test_counts.passed,
> +               "failed": test_counts.failed,
> +               "crashed": test_counts.crashed,
> +               "skipped": test_counts.skipped,
> +               "errors": test_counts.errors,
> +       }
>         test_group = {
>                 "name": test.name,
>                 "sub_groups": sub_groups,
>                 "test_cases": test_cases,
> +               "misc": counts_json
>         }
>         test_group.update(common_fields)
>         return test_group
>
> base-commit: c2493384e8110d5a4792fff4b9d46e47b78ea10a
> --
> 2.49.0.1101.gccaa498523-goog
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5281 bytes)