linux-kernel - Re: [PATCH v2 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKkY+ner_ZjPK9ZO7vjyvBdDA56emmgh9+MqVzaisCWfQ@mail.gmail.com>
Date: Fri, 16 May 2025 17:24:57 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: Shakeel Butt <shakeel.butt@...ux.dev>, Andrew Morton <akpm@...ux-foundation.org>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...nel.org>, 
	Roman Gushchin <roman.gushchin@...ux.dev>, Muchun Song <muchun.song@...ux.dev>, 
	Vlastimil Babka <vbabka@...e.cz>, Alexei Starovoitov <ast@...nel.org>, 
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Harry Yoo <harry.yoo@...cle.com>, 
	Yosry Ahmed <yosry.ahmed@...ux.dev>, bpf <bpf@...r.kernel.org>, 
	linux-mm <linux-mm@...ck.org>, 
	"open list:CONTROL GROUP (CGROUP)" <cgroups@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	Meta kernel team <kernel-team@...a.com>
Subject: Re: [PATCH v2 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs

On Thu, May 15, 2025 at 5:47 AM Lorenzo Stoakes
<lorenzo.stoakes@...cle.com> wrote:
>
> ----8<----
> From 28275e5d054506746d310cf5ebd1fafdb0881dba Mon Sep 17 00:00:00 2001
> From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> Date: Thu, 15 May 2025 13:43:46 +0100
> Subject: [PATCH] fix
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> ---
>  mm/memcontrol.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 2464a58fbf17..40fcc2259e5f 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3697,7 +3697,8 @@ static void mem_cgroup_free(struct mem_cgroup *memcg)
>
>  static struct mem_cgroup *mem_cgroup_alloc(struct mem_cgroup *parent)
>  {
> -       struct memcg_vmstats_percpu *statc, __percpu *pstatc_pcpu;
> +       struct memcg_vmstats_percpu *statc;
> +       struct memcg_vmstats_percpu __percpu *pstatc_pcpu;
>         struct mem_cgroup *memcg;
>         int node, cpu;
>         int __maybe_unused i;
> --
> 2.49.0

Tested-by: Alexei Starovoitov <ast@...nel.org>

Andrew,

Please pick up Lorenzo's fix into mm-new.