linux-kernel - Re: [PATCH] bus: fsl_mc: Fix driver_managed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <174747706458.12970.14926241943300392052.b4-ty@csgroup.eu>
Date: Sat, 17 May 2025 12:19:38 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: joro@...tes.org, will@...nel.org, Ioana Ciornei <ioana.ciornei@....com>,
        Robin Murphy <robin.murphy@....com>
Cc: Christophe Leroy <christophe.leroy@...roup.eu>, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        Will McVicker <willmcvicker@...gle.com>
Subject: Re: [PATCH] bus: fsl_mc: Fix driver_managed_dma check


On Fri, 25 Apr 2025 14:39:28 +0100, Robin Murphy wrote:
> Since it's not currently safe to take device_lock() in the IOMMU probe
> path, that can race against really_probe() setting dev->driver before
> attempting to bind. The race itself isn't so bad, since we're only
> concerned with dereferencing dev->driver itself anyway, but sadly my
> attempt to implement the check with minimal churn leads to a kind of
> TOCTOU issue, where dev->driver becomes valid after to_fsl_mc_driver(NULL)
> is already computed, and thus the check fails to work as intended.
> 
> [...]

Applied, thanks!

[1/1] bus: fsl_mc: Fix driver_managed_dma check
      commit: 152f33ee30ee6a7f4c15bedd7529dc5945315547

Best regards,
-- 
Christophe Leroy <christophe.leroy@...roup.eu>