linux-kernel - Re: [PATCH v2 2/9] dt-bindings: regulator: add pf1550

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a0f9e2a-cd70-4f61-8ffc-0c13e3396ada@kernel.org>
Date: Sat, 17 May 2025 13:13:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Samuel Kayode <samuel.kayode@...oirfairelinux.com>,
 Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Dmitry Torokho <dmitry.torokhov@...il.com>,
 Sebastian Reichel <sre@...nel.org>, Robin Gong <yibin.gong@....com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-imx@....com, linux-input@...r.kernel.org,
 Abel Vesa <abelvesa@...ux.com>, Abel Vesa <abel.vesa@....com>,
 Robin Gong <b38343@...escale.com>, Enric Balletbo Serra <eballetbo@...il.com>
Subject: Re: [PATCH v2 2/9] dt-bindings: regulator: add pf1550

On 16/05/2025 20:50, Samuel Kayode wrote:
> Add the DT binding document for pf1550 regulators.
> 
> Signed-off-by: Samuel Kayode <samuel.kayode@...oirfairelinux.com>
> ---
>  .../devicetree/bindings/regulator/pf1550.yaml | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/pf1550.yaml
> 
> diff --git a/Documentation/devicetree/bindings/regulator/pf1550.yaml b/Documentation/devicetree/bindings/regulator/pf1550.yaml
> new file mode 100644
> index 000000000000..a684ab974496
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/pf1550.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/pf1550.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Regulators for PF1550 PMIC from NXP.

Same comments as for other patch.

> +
> +maintainers:
> +  - Samuel Kayode <samuel.kayode@...oirfairelinux.com>
> +
> +description: |
> +  This module is part of the PF1550 MFD device. For more details
> +  see Documentation/devicetree/bindings/mfd/pf1550.yaml.
> +
> +  The regulator controller is represented as a sub-node of the PMIC node
> +  on the device tree.
> +
> +  The device has three LDO regulators, three buck converters and a DDR
> +  termination reference voltage.
> +
> +properties:
> +  compatible:
> +    const: fsl,pf1550-regulator

This looks not needed.

> +
> +patternProperties:
> +  "^(LDO[1-3]|SW[1-3]|VREFADDR)$":

Node names are lowercase.

> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible

Missing blank line

> +additionalProperties: false
> +
> +...

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>



Best regards,
Krzysztof