linux-kernel - Re: [PATCH v2 8/9] power: supply: pf1550: add battery charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f164a44b-331d-4f9b-825a-5ebc8ee47f24@kernel.org>
Date: Sat, 17 May 2025 13:20:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Samuel Kayode <samuel.kayode@...oirfairelinux.com>,
 Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Dmitry Torokhov
 <dmitry.torokhov@...il.com>, Sebastian Reichel <sre@...nel.org>,
 Robin Gong <yibin.gong@....com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 linux-imx@....com, linux-input@...r.kernel.org,
 Abel Vesa <abelvesa@...ux.com>, Abel Vesa <abel.vesa@....com>,
 Robin Gong <b38343@...escale.com>, Enric Balletbo Serra <eballetbo@...il.com>
Subject: Re: [PATCH v2 8/9] power: supply: pf1550: add battery charger support

On 16/05/2025 20:58, Samuel Kayode wrote:
> +
> +	chg->psy_desc.name = PF1550_CHARGER_NAME;
> +	chg->psy_desc.type = POWER_SUPPLY_TYPE_BATTERY;
> +	chg->psy_desc.get_property = pf1550_charger_get_property;
> +	chg->psy_desc.properties = pf1550_charger_props;
> +	chg->psy_desc.num_properties = ARRAY_SIZE(pf1550_charger_props);
> +
> +	chg->charger = devm_power_supply_register(&pdev->dev, &chg->psy_desc,
> +						  &psy_cfg);
> +	if (IS_ERR(chg->charger)) {
> +		dev_err(&pdev->dev, "failed: power supply register\n");
> +		ret = PTR_ERR(chg->charger);

Same comments as on patches before.

> +		return ret;
> +	}
> +
> +	ret = pf1550_reg_init(chg);
> +
> +	return ret;
> +}
> +
> +static void pf1550_charger_remove(struct platform_device *pdev)
> +{
> +	struct pf1550_charger *chg = platform_get_drvdata(pdev);
> +
> +	cancel_delayed_work_sync(&chg->irq_work);
> +}
> +
> +static const struct platform_device_id pf1550_charger_id[] = {
> +	{ "pf1550-charger", 0 },
> +	{ /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(platform, pf1550_charger_id);
> +
> +static struct platform_driver pf1550_charger_driver = {
> +	.driver = {
> +		.name	= "pf1550-charger",
> +	},
> +	.probe		= pf1550_charger_probe,
> +	.remove		= pf1550_charger_remove,
> +	.id_table	= pf1550_charger_id,
And this proves that your compatible in the binding is also useless. Not
used in the driver itself

Best regards,
Krzysztof