linux-kernel - Re: [PATCH net-next,v4] net: mana: Add handler for hardware servicing events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516180440.0db7b35a@kernel.org>
Date: Fri, 16 May 2025 18:04:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
 decui@...rosoft.com, stephen@...workplumber.org, kys@...rosoft.com,
 paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
 davem@...emloft.net, wei.liu@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, leon@...nel.org, longli@...rosoft.com,
 ssengar@...ux.microsoft.com, linux-rdma@...r.kernel.org,
 daniel@...earbox.net, john.fastabend@...il.com, bpf@...r.kernel.org,
 ast@...nel.org, hawk@...nel.org, tglx@...utronix.de,
 shradhagupta@...ux.microsoft.com, andrew+netdev@...n.ch,
 kotaranov@...rosoft.com, horms@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next,v4] net: mana: Add handler for hardware
 servicing events

On Wed, 14 May 2025 13:30:37 -0700 Haiyang Zhang wrote:
> +		dev_info(gc->dev, "Start MANA service type:%d\n", type);
> +		gc->in_service = true;
> +		mns_wk->pdev = to_pci_dev(gc->dev);
> +		INIT_WORK(&mns_wk->serv_work, mana_serv_func);
> +		schedule_work(&mns_wk->serv_work);

I don't see any refcounting in this patch, and the work is not
canceled. What if the device is removed between work being scheduled
and running?