linux-kernel - Re: [PATCH] platform/x86: thinkpad_acpi: Ignore battery threshold change event notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c69bc89-f5bd-4119-ba5d-3a004e8b81fc@gmx.de>
Date: Sat, 17 May 2025 18:00:20 +0200
From: Armin Wolf <W_Armin@....de>
To: Mark Pearson <mpearson-lenovo@...ebb.ca>
Cc: hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com,
 ibm-acpi-devel@...ts.sourceforge.net, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org, Derek Barbosa <debarbos@...hat.com>
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Ignore battery threshold
 change event notification

Am 17.05.25 um 04:33 schrieb Mark Pearson:

> If user modifies the battery charge threshold an ACPI event is generated.
> Confirmed with Lenovo FW team this is only generated on user event. As no
> action is needed, ignore the event and prevent spurious kernel logs.

Reviewed-by: Armin Wolf <W_Armin@....de>

Thanks,
Armin Wolf

> Reported-by: Derek Barbosa <debarbos@...hat.com>
> Closes: https://lore.kernel.org/platform-driver-x86/7e9a1c47-5d9c-4978-af20-3949d53fb5dc@app.fastmail.com/T/#m5f5b9ae31d3fbf30d7d9a9d76c15fb3502dfd903
> Signed-off-by: Mark Pearson <mpearson-lenovo@...ebb.ca>
> ---
>   drivers/platform/x86/thinkpad_acpi.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index 92b21e49faf6..657625dd60a0 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -231,6 +231,7 @@ enum tpacpi_hkey_event_t {
>   	/* Thermal events */
>   	TP_HKEY_EV_ALARM_BAT_HOT	= 0x6011, /* battery too hot */
>   	TP_HKEY_EV_ALARM_BAT_XHOT	= 0x6012, /* battery critically hot */
> +	TP_HKEY_EV_ALARM_BAT_LIM_CHANGE	= 0x6013, /* battery charge limit changed*/
>   	TP_HKEY_EV_ALARM_SENSOR_HOT	= 0x6021, /* sensor too hot */
>   	TP_HKEY_EV_ALARM_SENSOR_XHOT	= 0x6022, /* sensor critically hot */
>   	TP_HKEY_EV_THM_TABLE_CHANGED	= 0x6030, /* windows; thermal table changed */
> @@ -3777,6 +3778,10 @@ static bool hotkey_notify_6xxx(const u32 hkey, bool *send_acpi_ev)
>   		pr_alert("THERMAL EMERGENCY: battery is extremely hot!\n");
>   		/* recommended action: immediate sleep/hibernate */
>   		break;
> +	case TP_HKEY_EV_ALARM_BAT_LIM_CHANGE:
> +		pr_debug("Battery Info: battery charge threshold changed\n");
> +		/* User changed charging threshold. No action needed */
> +		return true;
>   	case TP_HKEY_EV_ALARM_SENSOR_HOT:
>   		pr_crit("THERMAL ALARM: a sensor reports something is too hot!\n");
>   		/* recommended action: warn user through gui, that */