linux-kernel - Re: [PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <iunafkwsdnr3c7tyzotxuv7wfg3restfhtms6clg27uxderp4l@bj4gnkqstwt7>
Date: Sat, 17 May 2025 18:49:35 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>, 
	konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, 
	quic_srichara@...cinc.com, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, quic_varada@...cinc.com
Subject: Re: [PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1
 gpio configurations

On Wed, Apr 09, 2025 at 09:36:00PM +0200, Konrad Dybcio wrote:
> On 3/18/25 7:49 AM, Manikanta Mylavarapu wrote:
> > Update the bias configuration for UART1 TX and RX pins to ensure correct
> > settings for RDP466.
> > 
> > Additionally, move the UART1 GPIO configurations from the common .dtsi
> > file to the RDP-specific .dts files to account for differing bias
> > configurations across RDPs of IPQ5424.
> > 
> > Fixes: 1a91d2a6021e ("arm64: dts: qcom: add IPQ5424 SoC and rdp466 board support")
> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
> > ---
> > Changes in V2:
> > 	- Consolidated uart1_tx_state and uart1_rx_state nodes into a
> > 	  single qup_uart1_default_state node, which includes the
> > 	  configuration for both UART1 TX and RX pins.
> > 	- Inserted a blank line before the status property in the UART1
> > 	  node.
> > 	- Fixed review comments from Kathiravan Thirumoorthy.
> > 
> >  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 19 ++++++++++++++++++-
> >  arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  7 -------
> >  2 files changed, 18 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > index b9752e8d579e..f0cba6b2be70 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > @@ -102,6 +102,22 @@ &ssphy_0 {
> >  };
> >  
> >  &tlmm {
> > +	qup_uart1_default_state: qup-uart1-default-state {
> > +		uart1-tx-pins {
> > +			pins = "gpio44";
> > +			function = "uart1";
> > +			drive-strength = <8>;
> > +			bias-pull-down;
> 
> Pull*down* on TX? Are there noise issues or similar?
> 

Pull down doesn't make sense to me either but I don't see any answer to
the question. If this is correct, please add a line/paragraph in the
commit message describing why this should be pulled down.

Dropping this from my review queue now.

Thanks,
Bjorn

> Konrad