linux-kernel - Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCmTQoJw6XG1CkuZ@gondor.apana.org.au>
Date: Sun, 18 May 2025 15:58:58 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Corentin Labbe <clabbe.montjoie@...il.com>
Cc: Klaus Kudielka <klaus.kudielka@...il.com>,
	Eric Biggers <ebiggers@...nel.org>, regressions@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
	Boris Brezillon <bbrezillon@...nel.org>,
	EBALARD Arnaud <Arnaud.Ebalard@....gouv.fr>,
	Romain Perier <romain.perier@...il.com>
Subject: Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor

On Sat, May 17, 2025 at 01:24:44PM +0200, Corentin Labbe wrote:
>
> Your patch didnt apply cleanly on cryptodev/master in tdma.c
> I have fixed at hand and the result is:
> http://kernel.montjoie.ovh/478852.log

Hah my debug patch was broken.  It didn't take into account the
partial block when recalculating the hash with the fallback.

However, this seems to suggest that my hunch was incorrect.  The
partial hash wasn't being corrupted and it's actually the final
calculation that was wrong.

This could be good news.  Because if it is a hardware bug causing
this, then the final calculation can be easily worked around by
turning the final hash into a partial update.

Let me crank out a debugging patch for that.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt