linux-kernel - [PATCH 2/2] HID: lenovo: Remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250518-hid_lenovo_acpi_dependency-v1-2-afdb93b5d1a6@jannau.net>
Date: Sun, 18 May 2025 12:18:38 +0200
From: Janne Grunau via B4 Relay <devnull+j.jannau.net@...nel.org>
To: Arnd Bergmann <arnd@...db.de>, Jiri Kosina <jikos@...nel.org>, 
 Benjamin Tissoires <bentiss@...nel.org>, 
 "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, 
 linux-acpi@...r.kernel.org, Janne Grunau <j@...nau.net>
Subject: [PATCH 2/2] HID: lenovo: Remove CONFIG_ACPI dependency

From: Janne Grunau <j@...nau.net>

With platform_profile_cycle() stubbed the dependency on CONFIG_ACPI can
be relaxed to `ACPI || !ACPI` and CONFIG_ACPI_PLATFORM_PROFILE is only
selected if ACPI is enabled.
Cycling through platform profiles is only functional with ACPI but that
should not be an issue as it only used on a detachable keyboard of a x86
tablet with a special connector.

Fixes: 52572cde8b4a4 ("HID: lenovo: select CONFIG_ACPI_PLATFORM_PROFILE")
Signed-off-by: Janne Grunau <j@...nau.net>
---
 drivers/hid/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index a503252702b7b43c332a12b14bc8b23b83e9f028..984f7bd235141f21e018b51f97546ec9d00324e8 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -595,8 +595,8 @@ config HID_LED

 config HID_LENOVO
 	tristate "Lenovo / Thinkpad devices"
-	depends on ACPI
-	select ACPI_PLATFORM_PROFILE
+	depends on ACPI || !ACPI
+	select ACPI_PLATFORM_PROFILE if ACPI
 	select NEW_LEDS
 	select LEDS_CLASS
 	help

-- 
2.49.0