linux-kernel - Re: [PATCH] ARM: integrator: Fix early initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <479ff23a-38eb-4861-823a-35ebbd748cd0@roeck-us.net>
Date: Sun, 18 May 2025 12:09:49 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Linus Walleij <linus.walleij@...aro.org>,
 Liviu Dudau <liviu.dudau@....com>, Sudeep Holla <sudeep.holla@....com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: integrator: Fix early initialization

On 5/18/25 10:47, Russell King (Oracle) wrote:
> On Sun, May 18, 2025 at 09:41:18AM -0700, Guenter Roeck wrote:
>> Starting with commit bdb249fce9ad4 ("ARM: integrator: read counter using
>> syscon/regmap"), intcp_init_early calls syscon_regmap_lookup_by_compatible
>> which in turn calls of_syscon_register. This function allocates memory.
>> Since the memory management code has not been initialized at that time,
>> the call always fails. It either returns -ENOMEM or crashes as follows.
> 
> Yet I see no thought whether having the scheduler see sched_clock()
> suddenly change is a good idea or not. The point of the initialisation
> being early is to avoid a jump in the scheduler clock.
> 
> So, was the commit you're trying to fix a good idea after all?
> 
> That question at least needs to be considered, rather than just moving
> stuff like this later.
>

Absolutely. Just consider this to be a bug report with a proposed fix.

Thanks,
Guenter