[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250519170004.631d99af@bootlin.com>
Date: Mon, 19 May 2025 17:00:04 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Andrew Lunn <andrew@...n.ch>, Greg Kroah-Hartman
<gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
Danilo Krummrich <dakr@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Michael
Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Andi
Shyti <andi.shyti@...nel.org>, Wolfram Sang
<wsa+renesas@...g-engineering.com>, Peter Rosin <peda@...ntia.se>, Derek
Kiernan <derek.kiernan@....com>, Dragan Cvetic <dragan.cvetic@....com>,
Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>, Saravana
Kannan <saravanak@...gle.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Mark
Brown <broonie@...nel.org>, Len Brown <lenb@...nel.org>, Daniel Scally
<djrscally@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>, Wolfram Sang <wsa@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>, linux-kernel@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-clk@...r.kernel.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-pci@...r.kernel.org,
linux-spi@...r.kernel.org, linux-acpi@...r.kernel.org, Allan Nielsen
<allan.nielsen@...rochip.com>, Horatiu Vultur
<horatiu.vultur@...rochip.com>, Steen Hegelund
<steen.hegelund@...rochip.com>, Luca Ceresoli <luca.ceresoli@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 23/26] misc: lan966x_pci: Introduce board specific
data
Hi Andy,
On Thu, 8 May 2025 22:21:41 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> On Wed, May 07, 2025 at 09:13:05AM +0200, Herve Codina wrote:
> > Only one device-tree overlay (lan966x_evb_lan9662_nic.dtbo) is handled
> > and this overlay is directly referenced in lan966x_pci_load_overlay().
> >
> > This avoid to use the code for an other board.
> >
> > In order to be more generic and to allow support for other boards (PCI
> > Vendor/Device IDs), introduce the lan966x_pci_info structure and attach
> > it to PCI Vendor/Device IDs handled by the driver.
> >
> > This structure contains information related to the PCI board such as
> > information related to the dtbo describing the board we have to load.
>
> ...
>
> > static struct pci_device_id lan966x_pci_ids[] = {
> > - { PCI_DEVICE(PCI_VENDOR_ID_EFAR, 0x9660) },
> > + { PCI_VDEVICE(EFAR, 0x9660), (kernel_ulong_t)&evb_lan9662_nic_info },
>
> PCI_DEVICE_DATA() ?
PCI_DEVICE_DATA() need the device ID defined using a #define in the form
PCI_DEVICE_ID_##vend##_##dev
PCI_VDEVICE() allows the device ID value passed as an integer in the same
way as for PCI_DEVICE().
Also, according to its kdoc, it allows the next field to follow as the
device private data.
IMHO, I think PCI_VDEVICE() use is correct here and I will keep it.
Best regards,
Hervé
Powered by blists - more mailing lists