linux-kernel - Re: [PATCH v2] dt-bindings: mmc: ti-omap: convert text based binding to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250519-unstamped-tabasco-05d9c7223289@spud>
Date: Mon, 19 May 2025 16:59:32 +0100
From: Conor Dooley <conor@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-mmc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: ti-omap: convert text based binding
 to json schema

On Mon, May 19, 2025 at 01:11:17PM +0000, Charan Pedumuru wrote:
> Convert TI MMC host controller binding to YAML format.
> Changes during Conversion:
> - Add new properties 'dma', 'dma-names' under required.
> - Define two separate phandles for 'dmas' in the examples.
> - Include appropriate header file for interrupts and use
>   it in the examples.
> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@...il.com>
> ---
> Changes in v2:
> - Added include statement for irq interrupt controller and
>   modified the interrupts under property to use header.
> - Changed maintainer to Rob Herring.
> - Defined two seperate phandles for 'dmas' under examples.
> - Rename the YAML file name to the compatible 'ti,omap2420-mmc'.
> - Added missing type and maxItems to 'ti,hwmods' under properties.
> - Link to v1: https://lore.kernel.org/r/20250510-ti-omap-v1-1-588b0ccb1823@gmail.com
> ---
>  .../devicetree/bindings/mmc/ti,omap2420-mmc.yaml   | 64 ++++++++++++++++++++++
>  Documentation/devicetree/bindings/mmc/ti-omap.txt  | 26 ---------
>  2 files changed, 64 insertions(+), 26 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/ti,omap2420-mmc.yaml b/Documentation/devicetree/bindings/mmc/ti,omap2420-mmc.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..195db77e0063b867f318ffc6b5f8811adb531515
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/ti,omap2420-mmc.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/ti,omap2420-mmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI MMC host controller for OMAP1 and 2420
> +
> +description:
> +  The MMC Host controller for TI OMAP1 and 2420 family provides
> +  an interface for MMC, SD and SDIO types of memory cards.
> +
> +allOf:
> +  - $ref: mmc-controller.yaml
> +
> +maintainers:
> +  - Rob Herring <robh@...nel.org>

This patch looks fine, but I don't want to ack this with Rob's name
there. Tony Lindgren <tony@...mide.com> wrote the original binding
as far as I saw from a quick check, maybe he's a more suitable pick?

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)