linux-kernel - Re: [PATCH] module: release codetag section when module load fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuCfpEeo2qKcyan9BnYGvEaYeso24wQT1eX-CxnBkjbEuY7sg@mail.gmail.com>
Date: Mon, 19 May 2025 09:03:16 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: David Wang <00107082@....com>
Cc: mcgrof@...nel.org, petr.pavlu@...e.com, linux-modules@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: release codetag section when module load fails

On Sun, May 18, 2025 at 3:12 AM David Wang <00107082@....com> wrote:
>
> When module load failed after memory for codetag sections ready,

nit: s/ready/is ready

> codetag section memory was not properly released. This
> causes memory leak, and if next module load happens to got the

nit: s/happens to got/happens to get


> same module address, codetag may pick the uninitialized section
> when manipulating tags during module unload, and lead to
> "unable to handle page fault" BUG.
>
> Closes: https://lore.kernel.org/all/20250516131246.6244-1-00107082@163.com/
> Signed-off-by: David Wang <00107082@....com>

Acked-by: Suren Baghdasaryan <surenb@...gle.com>

> ---
>  kernel/module/main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index a2859dc3eea6..5c6ab20240a6 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2829,6 +2829,7 @@ static void module_deallocate(struct module *mod, struct load_info *info)
>  {
>         percpu_modfree(mod);
>         module_arch_freeing_init(mod);
> +       codetag_free_module_sections(mod);
>
>         free_mod_mem(mod);
>  }
> --
> 2.39.2
>