[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPhsuW4UVkXdShpo2TvisPhr6S1jFPkS_BKXAjN9cT3=k5SAFg@mail.gmail.com>
Date: Mon, 19 May 2025 09:57:26 -0700
From: Song Liu <song@...nel.org>
To: Mark Rutland <mark.rutland@....com>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-toolchains@...r.kernel.org, live-patching@...r.kernel.org,
indu.bhagat@...cle.com, puranjay@...nel.org, wnliu@...gle.com,
irogers@...gle.com, joe.lawrence@...hat.com, jpoimboe@...nel.org,
peterz@...radead.org, roman.gushchin@...ux.dev, rostedt@...dmis.org,
will@...nel.org, kernel-team@...a.com
Subject: Re: [PATCH v3 1/2] arm64: Implement arch_stack_walk_reliable
Hi Mark,
Thanks for your review and the fixups!
On Mon, May 19, 2025 at 6:41 AM Mark Rutland <mark.rutland@....com> wrote:
>
[...]
>
> ... and then in future we can add anything spdecific to reliable
> stacktrace there.
>
> That aside, this generally looks good to me. The only thing that I note
> is that we're lacking a check on the return value of
> kretprobe_find_ret_addr(), and we should return -EINVAL when that is
> NULL, but that should never happen in normal operation.
>
> I've pushed a arm64/stacktrace-updates branch [1] with fixups for those
> as two separate commits atop this one. If that looks good to you I
> suggest we post that as a series and ask Will and Catalin to take that
> as-is.
>
> I'll look at the actual patching bits now.
>
> Mark.
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/ arm64/stacktrace-updates
For the fixups:
Reviewed-and-tested-by: Song Liu <song@...nel.org>
Tested with 2/2 of this set and samples/livepatch.
Song
Powered by blists - more mailing lists