linux-kernel - [PATCH v2 0/2] PCI: Separate reset and link code to separate files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250519171739.3575-1-ilpo.jarvinen@linux.intel.com>
Date: Mon, 19 May 2025 20:17:37 +0300
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org,
	Lukas Wunner <lukas@...ner.de>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Krishna Chaitanya Chundru <krishna.chundru@....qualcomm.com>,
	Shawn Anastasio <sanastasio@...torengineering.com>
Cc: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Subject: [PATCH v2 0/2] PCI: Separate reset and link code to separate files

pci.c has been catch-all for lots of code which didn't fit elsewhere,
making its footprint large.

Move reset and link related code into own files as they seem
independent enough from the other code and result in reasonably sized
.c files. While some of the code in link.c could have gone into
reset.c, reset.c would have become clearly larger and pcie_retrain_link()
wouldn't really have fit under reset.c so I thought independent link.c
would make sense and keep .c files in more manageable sizes.

The series is based on top of the pci/reset branch. Expected conflicts:
 - reset.c patch with:
   - PCI: Print the actual delay time in pci_bridge_wait_for_secondary_bus()
     (in pci/enumeration)
 - link.c patch with:
   - LBMS reset & update speed changes in the pci/bwctrl branch

There are some conflicts with some pending changes, the most imporant
being Mani's slot reset series:

https://lore.kernel.org/r/20250508-pcie-reset-slot-v4-0-7050093e2b50@linaro.org/

After these moves, the .c file sizes are:

  5295 pci.c
  3332 probe.c
   578 link.c
  1253 reset.c

I've been sit on top of the reset.c patch since the last Fall as there
have been just way too many complex conflicts to handle but currently
the conflict level would be relatively low.

In addition to these moves, I'm considering moving D0/D3 related logic
that is plenty in pci.c into own .c file (probably power.c but
suggestions welcome).

Ilpo Järvinen (2):
  PCI: Move reset and restore related code to reset-restore.c
  PCI: Move link related code into link.c

 drivers/pci/Makefile |    6 +-
 drivers/pci/link.c   |  578 +++++++++++++
 drivers/pci/pci.c    | 1890 ++++--------------------------------------
 drivers/pci/pci.h    |    5 +-
 drivers/pci/probe.c  |  194 -----
 drivers/pci/reset.c  | 1253 ++++++++++++++++++++++++++++
 6 files changed, 1977 insertions(+), 1949 deletions(-)
 create mode 100644 drivers/pci/link.c
 create mode 100644 drivers/pci/reset.c

base-commit: f3efb9569b4a21354ef2caf7ab0608a3e14cc6e4
-- 
2.39.5