linux-kernel - Re: [PATCH v3 0/2] Drivers: hv: Introduce new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250519182202.GA15054@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Date: Mon, 19 May 2025 11:22:02 -0700
From: Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
To: Naman Jain <namjain@...ux.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@...rosoft.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
	Roman Kisel <romank@...ux.microsoft.com>,
	Anirudh Rayabharam <anrayabh@...ux.microsoft.com>,
	Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>,
	Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
	ALOK TIWARI <alok.a.tiwari@...cle.com>,
	linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH v3 0/2] Drivers: hv: Introduce new driver - mshv_vtl

On Mon, May 19, 2025 at 10:26:40AM +0530, Naman Jain wrote:
> Introduce a new mshv_vtl driver to provide an interface for Virtual
> Machine Monitor like OpenVMM and its use as OpenHCL paravisor to
> control VTL0 (Virtual trust Level).
> Expose devices and support IOCTLs for features like VTL creation,
> VTL0 memory management, context switch, making hypercalls,
> mapping VTL0 address space to VTL2 userspace, getting new VMBus
> messages and channel events in VTL2 etc.
> 
> OpenVMM : https://openvmm.dev/guide/
> 
> Changes since v2:
> https://lore.kernel.org/all/20250512140432.2387503-1-namjain@linux.microsoft.com/
> * Removed CONFIG_OF dependency (addressed Saurabh's comments
> * Fixed typo in "allow_map_intialized" variable name
> 
> Changes since v1:
> https://lore.kernel.org/all/20250506084937.624680-1-namjain@linux.microsoft.com/
> Addressed Saurabh's comments:
> * Split the patch in 2 to keep export symbols separate
> * Make MSHV_VTL module tristate and fixed compilation warning that would come when HYPERV is
>   compiled as a module.
> * Remove the use of ref_count
> * Split functionality of mshv_vtl_ioctl_get_set_regs to different functions
>   mshv_vtl_ioctl_(get|set)_regs as it actually make things simpler
> * Fixed use of copy_from_user in atomic context in mshv_vtl_hvcall_call.
>   Added ToDo comment for info.
> * Added extra code to free memory for vtl in error scenarios in mshv_ioctl_create_vtl()
> 
> Addressed Alok's comments regarding:
> * Additional conditional checks
> * corrected typo in HV_X64_REGISTER_MSR_MTRR_PHYS_MASKB case
> * empty lines before return statement
> * Added/edited comments, variable names, structure field names as suggested to improve
>   documentation - no functional change here.
> 
> Naman Jain (2):
>   Drivers: hv: Export some symbols for mshv_vtl
>   Drivers: hv: Introduce mshv_vtl driver
> 
>  drivers/hv/Kconfig          |   20 +
>  drivers/hv/Makefile         |    7 +-
>  drivers/hv/hv.c             |    2 +
>  drivers/hv/hyperv_vmbus.h   |    1 +
>  drivers/hv/mshv_vtl.h       |   52 +
>  drivers/hv/mshv_vtl_main.c  | 1783 +++++++++++++++++++++++++++++++++++
>  drivers/hv/vmbus_drv.c      |    3 +-
>  include/hyperv/hvgdk_mini.h |   81 ++
>  include/hyperv/hvhdk.h      |    1 +
>  include/uapi/linux/mshv.h   |   82 ++
>  10 files changed, 2030 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/hv/mshv_vtl.h
>  create mode 100644 drivers/hv/mshv_vtl_main.c
> 
> 
> base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
> -- 
> 2.34.1
> 

For both the patches,
Reviewed-by: Saurabh Sengar <ssengar@...ux.microsoft.com>