linux-kernel - Re: [V1 1/2] arm stm32mp131.dtsi: add "encoding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <192d4c26-3733-4818-8dc1-43d736fdbf75@kernel.org>
Date: Mon, 19 May 2025 20:35:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rodolfo Giometti <giometti@...eenne.com>, linux-kernel@...r.kernel.org
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Eric Fourmont <eric.fourmont-ext@...com>,
 Yann GAUTIER <yann.gautier@...s.st.com>
Subject: Re: [V1 1/2] arm stm32mp131.dtsi: add "encoding_mode" nvmem
 definition

On 19/05/2025 15:08, Rodolfo Giometti wrote:
> This patch adds the definition for the nvmem location "encoding_mode"

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> related to the "cpu0" node.
> 
> Signed-off-by: Rodolfo Giometti <giometti@...eenne.com>
> ---
>  arch/arm/boot/dts/st/stm32mp131.dtsi | 7 +++++++

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
> index e555717c0048..52bf497e26bb 100644
> --- a/arch/arm/boot/dts/st/stm32mp131.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
> @@ -24,6 +24,9 @@ cpu0: cpu@0 {
>  			clocks = <&scmi_perf 0>;
>  			clock-names = "cpu";
>  			#cooling-cells = <2>;
> +
> +			nvmem-cells = <&encoding_mode_otp>;
> +			nvmem-cell-names = "encoding_mode";

Are you sure this passes dtbs_check?

Best regards,
Krzysztof