linux-kernel - Re: [PATCH v2 0/2] iio: dac: adi-axi-dac: fix for wrong bus read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <l7e6pddcnlj6jjiqeyotozxgese7hl6zkpbli3h2zsfjkezksv@gw2qvb3muzt3>
Date: Mon, 19 May 2025 21:03:29 +0200
From: Angelo Dureghello <adureghello@...libre.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Nuno Sa <nuno.sa@...log.com>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, David Lechner <dlechner@...libre.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] iio: dac: adi-axi-dac: fix for wrong bus read

Hi Jonathan,

i did a mistake on the second patch 2/2.

in axi_dac_wait_bus_free()

	ret = regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, val,
		FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == -1, 10,

must be

	ret = regmap_read_poll_timeout(st->regmap, AXI_DAC_UI_STATUS_REG, val,
		FIELD_GET(AXI_DAC_UI_STATUS_IF_BUSY, val) == 0, 10,

Not clear what's happen, i missed something while testing.

I apologize, not sure if it is already queued, please let me know
how to fix it.

Regards,
angelo


On 05.05.2025 13:38, Jonathan Cameron wrote:
> On Mon, 5 May 2025 13:33:16 +0200
> Angelo Dureghello <adureghello@...libre.com> wrote:
> 
> > Hi Jonathan,
> > 
> > asking info about this patch.
> > 
> > As explained, would not do anything else here, please let me know if it can
> > be accepted or how to proceed.
> I've queued up patch 1 as a fix.  Patch 2 will need to wait on that.
> 
> > 
> > Thanks a lot,
> > angelo
> > 
> > On 09.04.2025 14:57, Nuno Sá wrote:
> > > On Wed, 2025-04-09 at 11:16 +0200, Angelo Dureghello wrote:  
> > > > This patchset is intended to fix a random wrong chip ID read, or a
> > > > scratchpad test mismatch, tests done in the ad3552r-hs driver probe. The 
> > > > bus "read" operation must always check for busy flag before reading.
> > > > 
> > > > First patch reorganizes a bit the busy-wait polling code, second patch
> > > > fixes the wrong bus read occurence. 
> > > > 
> > > > NOTE: due to ongoing changes in adi-axi-dac.c, this patch is intended to be
> > > > applied after the linked "ramp generator" patch.
> > > > 
> > > > Link:
> > > > https://lore.kernel.org/linux-iio/20250408-wip-bl-ad3552r-fixes-v4-0-b33c0264bd78@baylibre.com
> > > > Signed-off-by: Angelo Dureghello <adureghello@...libre.com>
> > > > ---  
> > > 
> > > LGTM,
> > > 
> > > Reviewed-by: Nuno Sá <nuno.sa@...log.com>
> > >   
> > > > Changes in v2:
> > > > - invert patch order, fix first.
> > > > - Link to v1:
> > > > https://lore.kernel.org/r/20250408-ad3552r-fix-bus-read-v1-0-37add66aeb08@baylibre.com
> > > > 
> > > > ---
> > > > Angelo Dureghello (2):
> > > >       iio: dac: adi-axi-dac: fix bus read
> > > >       iio: dac: adi-axi-dac: use unique bus free check
> > > > 
> > > >  drivers/iio/dac/adi-axi-dac.c | 40 +++++++++++++++++++++++++---------------
> > > >  1 file changed, 25 insertions(+), 15 deletions(-)
> > > > ---
> > > > base-commit: 6fb85f14853ddde06d57030c753168402bf69cd9
> > > > change-id: 20250408-ad3552r-fix-bus-read-1522622fbd2b
> > > > 
> > > > Best regards,  
> > 
>