linux-kernel - Re: [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and oversampling ratio attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4843ec52-57e2-418a-b640-8e05ba60959e@baylibre.com>
Date: Mon, 19 May 2025 15:15:43 -0500
From: David Lechner <dlechner@...libre.com>
To: 1aff0f813bb3fee55c5483be860b6885abdb81e5.1747175187.git.Jonathan.Santos@...log.com,
 Jonathan Santos <Jonathan.Santos@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, andy@...nel.org,
 nuno.sa@...log.com, Michael.Hennerich@...log.com,
 marcelo.schmitt@...log.com, jic23@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, marcelo.schmitt1@...il.com,
 linus.walleij@...aro.org, brgl@...ev.pl, lgirdwood@...il.com,
 broonie@...nel.org, Pop Paul <paul.pop@...log.com>
Subject: Re: [PATCH v8 10/11] iio: adc: ad7768-1: add filter type and
 oversampling ratio attributes

On 5/19/25 12:13 PM, Jonathan Santos wrote:
> On 05/15, Jonathan Santos wrote:

...
>> +
>> +/* Decimation Rate range for each filter type */
>> +static const int ad7768_dec_rate_range[][3] = {
>> +	[AD7768_FILTER_SINC5] = { 8, 8, 1024 },
>> +	[AD7768_FILTER_SINC3] = { 32, 32, 163840 },
>> +	[AD7768_FILTER_WIDEBAND] = { 32, 32, 1024 },
>> +	[AD7768_FILTER_SINC3_REJ60] = { 32, 32, 163840 },
>> +};
>> +
> 
> Since we're still discussing some points — is the `step` in 
> `[min step max]` for the IIO range additive or multiplicative? It is not 
> clear on documentation, maybe on purpose or I have missed something.
> 
> Here, decimation/OSR doubles from 8 or 32 for SINC5/WIDEBAND, and is a 
> multiple of 32 for SINC3. So I'm still unsure how to represent this to be
> clear to the user.

Sounds to me like sinc5/wideband should be lists instead of ranges.
It is only 6 values.