linux-kernel - Re: [PATCH v3] ufs: core: Add HID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08e67735-d5b0-47d0-b476-c22a3b5acdda@acm.org>
Date: Mon, 19 May 2025 14:02:41 -0700
From: Bart Van Assche <bvanassche@....org>
To: Huan Tang <tanghuan@...o.com>, alim.akhtar@...sung.com,
 avri.altman@....com, James.Bottomley@...senPartnership.com,
 martin.petersen@...cle.com, matthias.bgg@...il.com,
 angelogioacchino.delregno@...labora.com, peter.wang@...iatek.com,
 manivannan.sadhasivam@...aro.org, quic_nguyenb@...cinc.com,
 luhongfei@...o.com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Cc: opensource.kernel@...o.com, Wenxing Cheng <wenxing.cheng@...o.com>
Subject: Re: [PATCH v3] ufs: core: Add HID support

On 5/18/25 7:29 PM, Huan Tang wrote:
> Follow JESD220G, support HID(Host Initiated Defragmentation)
> through sysfs, the relevant sysfs nodes are as follows:
> 	1.analysis_trigger
> 	2.defrag_trigger
> 	3.fragmented_size
> 	4.defrag_size
> 	5.progress_ratio
> 	6.state
> The detailed definition	of the six nodes can be	found in the sysfs
> documentation.
> 
> HID's execution policy is given to user-space.
> 
> Changelog
> ===
> v2 - > v3:
> 	1.Remove the "ufs_" prefix from directory name
> 	2.Remove the "hid_" prefix from node names
> 	3.Make "ufs" appear only once in the HID group name
> 	4.Add "is_visible" callback for "ufs_sysfs_hid_group"
> v1 - > v2:
> 	1.Refactor the HID code according to Bart and Peter and
> 	Arvi's suggestions
> 
> v2
> 	https://lore.kernel.org/all/20250512131519.138-1-tanghuan@vivo.com/
> v1
> 	https://lore.kernel.org/all/20250417125008.123-1-tanghuan@vivo.com/
> 
> Signed-off-by: Huan Tang <tanghuan@...o.com>
> Signed-off-by: Wenxing Cheng <wenxing.cheng@...o.com>
> ---

The patch changelog should occur below the three hyphens (---) such that
it doesn't end up in the kernel changelog. Otherwise this patch looks
good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@....org>