linux-kernel - Re: [PATCH] selftests/futex: Fix usage() message to clarify timeout value unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2ebb7982-5462-4ca0-9936-f0821cbb9036@igalia.com>
Date: Mon, 19 May 2025 18:21:06 -0300
From: André Almeida <andrealmeid@...lia.com>
To: Jonathan Velez <jonvelez12345@...il.com>, tglx@...utronix.de,
 mingo@...hat.com, peterz@...radead.org, dvhart@...radead.org,
 dave@...olabs.net, shuah@...nel.org
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/futex: Fix usage() message to clarify timeout
 value unit

Hi Jonathan,

Em 19/05/2025 17:30, Jonathan Velez escreveu:
> 
> 
>> On May 15, 2025, at 1:45 PM, Jonathan Velez <jonvelez12345@...il.com> wrote:
>>
>> futex_wait_timeout: Fix usage() message to clarify timeout value unit
>>
>> Signed-off-by: Jonathan Velez <jonvelez12345@...il.com>
>> ---
>> tools/testing/selftests/futex/functional/futex_wait_timeout.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/futex/functional/futex_wait_timeout.c b/tools/testing/selftests/futex/functional/futex_wait_timeout.c
>> index d183f878360b..737475df9242 100644
>> --- a/tools/testing/selftests/futex/functional/futex_wait_timeout.c
>> +++ b/tools/testing/selftests/futex/functional/futex_wait_timeout.c
>> @@ -31,7 +31,7 @@ void usage(char *prog)
>> 	printf("Usage: %s\n", prog);
>> 	printf("  -c	Use color\n");
>> 	printf("  -h	Display this help message\n");
>> -	printf("  -t N	Timeout in nanoseconds (default: 100,000)\n");
>> +	printf("  -t N	Set timeout duration in nanoseconds (default: 100,000 ns = 100 us)\n");
>> 	printf("  -v L	Verbosity level: %d=QUIET %d=CRITICAL %d=INFO\n",
>> 	       VQUIET, VCRITICAL, VINFO);
>> }
>> -- 
>> 2.43.0
>>
>     Hello,
>     
>     I’m following up on the validity of this Patch.
>     
>     Best Regards,
>     Jonathan Velez
> 

I think the current string already states what's the value unit of the 
timeout in nanoseconds and is good as it is.