linux-kernel - Re: [PATCH linux next] taskstat: add explain about xxx_delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505191436188855ReOYCghNWSoD1i2A4r9h@zte.com.cn>
Date: Mon, 19 May 2025 14:36:18 +0800 (CST)
From: <xu.xin16@....com.cn>
To: <jiang.kun2@....com.cn>, <wang.yaxin@....com.cn>
Cc: <yang.yang29@....com.cn>, <bbonev@...uan.org>,
        <linux-kernel@...r.kernel.org>, <bsingharora@...il.com>,
        <jiang.kun2@....com.cn>, <akpm@...ux-foundation.org>,
        <wang.yaxin@....com.cn>
Subject: Re: [PATCH linux next] taskstat: add explain about xxx_delay_min/max and adjust
 indentation

> add explain about xxx_delay_min/max and adjust indentation.
> 
> Signed-off-by: Wang Yaxin <wang.yaxin@....com.cn>
> Signed-off-by: Jiang Kun <jiang.kun2@....com.cn>
> ---
>  include/uapi/linux/taskstats.h | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/include/uapi/linux/taskstats.h b/include/uapi/linux/taskstats.h
> index d71aa022b2ef..62e2d7f65298 100644
> --- a/include/uapi/linux/taskstats.h
> +++ b/include/uapi/linux/taskstats.h
> @@ -207,6 +207,12 @@ struct taskstats {
>  	/* v15: add Delay max and Delay min */
> 
>  	/* v16: move Delay max and Delay min to the end of taskstat */
> +	/*
> +	 *
> +	 * xxx_delay_max is the max number of delay values recorded
> +	 * xxx_delay_min is the min number of delay values recorded
> +	 *
> +	 */

The naming of these variables is sufficiently clear and self-explanatory, so no need to add these comments.

> @@ -225,11 +231,11 @@ struct taskstats {
>  	__u64	compact_delay_max;
>  	__u64	compact_delay_min;
> 
> -	__u64    wpcopy_delay_max;
> -	__u64    wpcopy_delay_min;
> +	__u64	wpcopy_delay_max;
> +	__u64	wpcopy_delay_min;
> 
> -	__u64    irq_delay_max;
> -	__u64    irq_delay_min;
> +	__u64	irq_delay_max;
> +	__u64	irq_delay_min;
>  };

this change is ok.