linux-kernel - Re: [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is enabled.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87cyc5nl6q.fsf@geanix.com>
Date: Mon, 19 May 2025 08:55:57 +0200
From: Esben Haabendal <esben@...nix.com>
To: "Alexander Stein" <alexander.stein@...tq-group.com>
Cc: "Dong Aisheng" <aisheng.dong@....com>,  "Fabio Estevam"
 <festevam@...il.com>,  "Shawn Guo" <shawnguo@...nel.org>,  "Jacky Bai"
 <ping.bai@....com>,  "Pengutronix Kernel Team" <kernel@...gutronix.de>,
  "NXP S32 Linux Team" <s32@....com>,  "Linus Walleij"
 <linus.walleij@...aro.org>,  <linux-gpio@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] pinctrl: freescale: Enable driver if platform is
 enabled.

"Alexander Stein" <alexander.stein@...tq-group.com> writes:

> The pinctrl drivers are not enabled in defconfig. Instead of listing
> each driver in the defconfig, enable then by default if the platform/soc
> support is enabled as well.
>
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> Changes in v3:
> * None
>
> Changes in v2:
> * default pinctrl driver depending on SoC support
>
> The discussion at [1] resulted it is better to default SoC-specific pinctrl
> drivers to thei SoC support instead of adding to defconfig or selecting
> pinctrl.
>
> [1] https://lore.kernel.org/all/20250507124414.3088510-1-alexander.stein@ew.tq-group.com/
>
>  drivers/pinctrl/freescale/Kconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig
> index d1610e2f21427..8d24decd3f074 100644
> --- a/drivers/pinctrl/freescale/Kconfig
> +++ b/drivers/pinctrl/freescale/Kconfig
> @@ -22,6 +22,7 @@ config PINCTRL_IMX_SCU
>  	tristate
>  	depends on OF
>  	depends on IMX_SCU || COMPILE_TEST
> +	default IMX_SCU
>  	select PINCTRL_IMX
>
>  config PINCTRL_IMX1_CORE
> @@ -160,6 +161,7 @@ config PINCTRL_IMX8MM
>  	tristate "IMX8MM pinctrl driver"
>  	depends on OF
>  	depends on SOC_IMX8M || COMPILE_TEST
> +	default SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
>  	  Say Y here to enable the imx8mm pinctrl driver
> @@ -168,6 +170,7 @@ config PINCTRL_IMX8MN
>  	tristate "IMX8MN pinctrl driver"
>  	depends on OF
>  	depends on SOC_IMX8M || COMPILE_TEST
> +	default SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
>  	  Say Y here to enable the imx8mn pinctrl driver
> @@ -176,6 +179,7 @@ config PINCTRL_IMX8MP
>  	tristate "IMX8MP pinctrl driver"
>  	depends on OF
>  	depends on SOC_IMX8M || COMPILE_TEST
> +	default SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
>  	  Say Y here to enable the imx8mp pinctrl driver
> @@ -184,6 +188,7 @@ config PINCTRL_IMX8MQ
>  	tristate "IMX8MQ pinctrl driver"
>  	depends on OF
>  	depends on SOC_IMX8M || COMPILE_TEST
> +	default SOC_IMX8M
>  	select PINCTRL_IMX
>  	help
>  	  Say Y here to enable the imx8mq pinctrl driver
> @@ -192,6 +197,7 @@ config PINCTRL_IMX8QM
>  	tristate "IMX8QM pinctrl driver"
>  	depends on OF
>  	depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> +	default ARCH_MXC
>  	select PINCTRL_IMX_SCU
>  	help
>  	  Say Y here to enable the imx8qm pinctrl driver
> @@ -200,6 +206,7 @@ config PINCTRL_IMX8QXP
>  	tristate "IMX8QXP pinctrl driver"
>  	depends on OF
>  	depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> +	default ARCH_MXC
>  	select PINCTRL_IMX_SCU
>  	help
>  	  Say Y here to enable the imx8qxp pinctrl driver
> @@ -208,6 +215,7 @@ config PINCTRL_IMX8DXL
>  	tristate "IMX8DXL pinctrl driver"
>  	depends on OF
>  	depends on (IMX_SCU && ARCH_MXC && ARM64) || COMPILE_TEST
> +	default ARCH_MXC
>  	select PINCTRL_IMX_SCU
>  	help
>  	  Say Y here to enable the imx8dxl pinctrl driver
> @@ -216,6 +224,7 @@ config PINCTRL_IMX8ULP
>  	tristate "IMX8ULP pinctrl driver"
>  	depends on OF
>  	depends on ARCH_MXC || COMPILE_TEST
> +	default ARCH_MXC
>  	select PINCTRL_IMX
>  	help
>  	  Say Y here to enable the imx8ulp pinctrl driver
> @@ -240,6 +249,7 @@ config PINCTRL_IMX93
>  	tristate "IMX93 pinctrl driver"
>  	depends on OF
>  	depends on ARCH_MXC || COMPILE_TEST
> +	default SOC_IMX9
>  	select PINCTRL_IMX
>  	help
>  	  Say Y here to enable the imx93 pinctrl driver
> --
> 2.43.0

Acked-by: Esben Haabendal <esben@...nix.com>