linux-kernel - Re: [PATCH v9 2/5] crypto: loongson - add Loongson RNG driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCrqPnwr7lMJNOnL@gondor.apana.org.au>
Date: Mon, 19 May 2025 16:22:22 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Qunqin Zhao <zhaoqunqin@...ngson.cn>
Cc: lee@...nel.org, davem@...emloft.net, peterhuewe@....de,
	jarkko@...nel.org, linux-kernel@...r.kernel.org,
	loongarch@...ts.linux.dev, linux-crypto@...r.kernel.org,
	jgg@...pe.ca, linux-integrity@...r.kernel.org,
	pmenzel@...gen.mpg.de, Yinggang Gu <guyinggang@...ngson.cn>,
	Huacai Chen <chenhuacai@...ngson.cn>
Subject: Re: [PATCH v9 2/5] crypto: loongson - add Loongson RNG driver support

On Mon, May 19, 2025 at 04:13:14PM +0800, Qunqin Zhao wrote:
>
> Then the HISI TRNG driver isn't a right demo?

Yes the hisi trng looks wrong too.

> This can also avoid concurrent access to a device, otherwise i need to
> 
> add mutex_lock/unlock in generate and seed callback.

Randomly failing the tfm allocation is not a solution to resource
control :)

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt