linux-kernel - Re: [RFC PATCH v2 06/12] sched: Adapt sched tracepoints for RV task model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5385360f8f01a213ec3918dbc341f48339d7b8e5.camel@redhat.com>
Date: Mon, 19 May 2025 10:41:47 +0200
From: Gabriele Monaco <gmonaco@...hat.com>
To: Nam Cao <namcao@...utronix.de>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>, Peter
 Zijlstra <peterz@...radead.org>, Steven Rostedt <rostedt@...dmis.org>,
 Masami Hiramatsu	 <mhiramat@...nel.org>,
 linux-trace-kernel@...r.kernel.org, Tomas Glozar	 <tglozar@...hat.com>,
 Juri Lelli <jlelli@...hat.com>
Subject: Re: [RFC PATCH v2 06/12] sched: Adapt sched tracepoints for RV task
 model

On Mon, 2025-05-19 at 10:29 +0200, Nam Cao wrote:
> On Wed, May 14, 2025 at 10:43:08AM +0200, Gabriele Monaco wrote:
> >  DECLARE_TRACE_CONDITION(sched_set_state_tp,
> > -	TP_PROTO(struct task_struct *tsk, int state),
> > -	TP_ARGS(tsk, state),
> > +	TP_PROTO(struct task_struct *tsk, int state, bool
> > from_signal),
> > +	TP_ARGS(tsk, state, from_signal),
> >  	TP_CONDITION(!!(tsk->__state) != !!state));
> 
> Doesn't this break the build? Because the monitors still use the old
> signatures?
> 
> I understand you adapt the monitor to this new signature in a follow-
> up
> patch. But every commits in the series should be buildable, otherwise
> you
> break "git bisect".
> 

Yeah good point, do you suggest at least fixing signatures in monitors
inside this commit?
I can keep the other commits to actually fix/adapt monitors but at
least allow building from here.

Thanks,
Gabriele