linux-kernel - Re: [PATCH v2 0/5] SC8280XP SLPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCr7UzmK7XCjpsOx@hovoldconsulting.com>
Date: Mon, 19 May 2025 11:35:15 +0200
From: Johan Hovold <johan@...nel.org>
To: Konrad Dybcio <konradybcio@...nel.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Subject: Re: [PATCH v2 0/5] SC8280XP SLPI

On Sat, May 17, 2025 at 07:27:49PM +0200, Konrad Dybcio wrote:
> SC8280XP features a SLPI, much like its distant relative, SM8350.

Please get into the habit of spelling out *and* explaining internal
Qualcomm acronyms like "SLPI" so that your cover letter and commit
messages makes sense to people outside of Qualcomm.

Also say something about whether and how this is useful for anyone
currently or if it, for example, depends on Qualcomm proprietary user
space bits.

> Dmitry Baryshkov (1):
>       arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP

At first I was worried that missing firmware could cause issues here
(e.g. drivers not reaching sync state as with venus), but Lenovo has
indeed released the SLPI firmware already.

Are there any other potential downsides to enabling this (e.g. before
anyone can actually use the sensors)?

> Konrad Dybcio (4):
>       dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP
>       arm64: dts: qcom: sc8280xp: Fix node order
>       arm64: dts: qcom: sc8280xp: Add SLPI

>       arm64: dts: qcom: sc8280xp-crd: Enable SLPI

Without firmware this results in errors like:

	remoteproc remoteproc0: slpi is available
	remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2
	remoteproc remoteproc0: powering up slpi
	remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2
	remoteproc remoteproc0: request_firmware failed: -2

but enabling for the CRD reference design and requiring users (read:
developers) to copy it from Windows should be OK.

Johan