linux-kernel - Re: [PATCH] mfd: 88pm886: Constify struct regmap_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DA018S0Q8E24.2KK8DE7QWLZTX@matfyz.cz>
Date: Mon, 19 May 2025 11:34:03 +0200
From: "Karel Balej" <balejk@...fyz.cz>
To: "Christophe JAILLET" <christophe.jaillet@...adoo.fr>,
        "Lee Jones"
 <lee@...nel.org>
Cc: <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] mfd: 88pm886: Constify struct regmap_irq_chip and some
 other structures

Christophe JAILLET, 2025-05-11T22:42:30+02:00:
> 'struct regmap_irq_chip' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some

increases

> function pointers.
>
> While at it, also constify some other structures.
>
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>    5032	   3304	     64	   8400	   20d0	drivers/mfd/88pm886.o
>
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>    5800	   2536	     64	   8400	   20d0	drivers/mfd/88pm886.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested-only.
> ---
>  drivers/mfd/88pm886.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Karel Balej <balejk@...fyz.cz>

Thanks,
K. B.