linux-kernel - Re: [PATCH 3/9] ASoC: apple: mca: Move clock shutdown to backend shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d590b26c-67b1-4fa9-8659-2665e73a6aae@sirena.org.uk>
Date: Mon, 19 May 2025 11:38:00 +0100
From: Mark Brown <broonie@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Martin Povišer <povik+lin@...ebit.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	asahi@...ts.linux.dev, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, Hector Martin <marcan@...can.st>
Subject: Re: [PATCH 3/9] ASoC: apple: mca: Move clock shutdown to backend
 shutdown

On Sun, May 18, 2025 at 08:50:48PM +1000, James Calligeros wrote:
> From: Hector Martin <marcan@...can.st>
> 
> Codecs are set to mute after hw_free, so yanking the clock out from
> under them in hw_free leads to breakage. Move the clock shutdown to the
> shutdown op, which is late enough.

The mute should be the first thing that happens, before we do the DAPM
stream stop event or hw_free() for precisely this reason?  See
soc_pcm_hw_clean().  The reason we do the mute is to cover any glitches
introduced into the stream during the teardown process.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)