linux-kernel - Re: [PATCH v4] cpufreq: scmi: Skip SCMI devices that aren't used by the CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250519104012.acyfoffelestwgtt@vireshk-i7>
Date: Mon, 19 May 2025 16:10:12 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Mike Tipton <quic_mdtipton@...cinc.com>
Cc: Sudeep Holla <sudeep.holla@....com>,
	Cristian Marussi <cristian.marussi@....com>,
	"Rafael J. Wysocki" <rafael@...nel.org>, arm-scmi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....nxp.com>,
	Peng Fan <peng.fan@....com>
Subject: Re: [PATCH v4] cpufreq: scmi: Skip SCMI devices that aren't used by
 the CPUs

On 14-05-25, 20:53, Mike Tipton wrote:
> Currently, all SCMI devices with performance domains attempt to register
> a cpufreq driver, even if their performance domains aren't used to
> control the CPUs. The cpufreq framework only supports registering a
> single driver, so only the first device will succeed. And if that device
> isn't used for the CPUs, then cpufreq will scale the wrong domains.
> 
> To avoid this, return early from scmi_cpufreq_probe() if the probing
> SCMI device isn't referenced by the CPU device phandles.
> 
> This keeps the existing assumption that all CPUs are controlled by a
> single SCMI device.
> 
> Signed-off-by: Mike Tipton <quic_mdtipton@...cinc.com>
> Reviewed-by: Peng Fan <peng.fan@....com>
> Reviewed-by: Cristian Marussi <cristian.marussi@....com>
> Reviewed-by: Sudeep Holla <sudeep.holla@....com>
> Tested-by: Cristian Marussi <cristian.marussi@....com>

Applied. Thanks.

-- 
viresh