linux-kernel - Re: Re: [PATCH v2] ufs: core: Add HID support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250519023833.343-1-tanghuan@vivo.com>
Date: Mon, 19 May 2025 10:38:33 +0800
From: Huan Tang <tanghuan@...o.com>
To: bvanassche@....org
Cc: James.Bottomley@...senPartnership.com,
	alim.akhtar@...sung.com,
	angelogioacchino.delregno@...labora.com,
	avri.altman@....com,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-mediatek@...ts.infradead.org,
	linux-scsi@...r.kernel.org,
	luhongfei@...o.com,
	manivannan.sadhasivam@...aro.org,
	martin.petersen@...cle.com,
	matthias.bgg@...il.com,
	opensource.kernel@...o.com,
	peter.wang@...iatek.com,
	quic_nguyenb@...cinc.com,
	tanghuan@...o.com,
	wenxing.cheng@...o.com
Subject: Re: Re: [PATCH v2] ufs: core: Add HID support

Hi bart sir,

Thank you for your comments and guidance！
The v3 patch：
https://lore.kernel.org/all/20250519022912.292-1-tanghuan@vivo.com/

> All HID sysfs attributes occur in the "ufs_hid" directory and have a
> "hid_" prefix. That's two times "hid". Please remove the "hid_" prefix
> from the sysfs attribute names since it is redundant.
OK! It has been modified in the v3 patch.

> Isn't the prefix "ufs_" in "ufs_hid" redundant since this sysfs group
> occurs under a UFS host controller directory?
OK! It has been modified in the v3 patch.

> Regarding the name of this sysfs group, "ufs" occurs twice in that
> name (ufs_sysfs_ufs_hid_group). Please make sure that "ufs" only occurs
> once in that sysfs group name.
OK! It has been modified in the v3 patch.

> Please merge ufs_sysfs_ufs_hid_group into ufs_sysfs_groups, remove the
> new sysfs_create_group() call and add a visibility callback in
> ufs_sysfs_ufs_hid_group that only makes the attributes in this group
> visible if hba->dev_info.hid_sup == true.
OK! It has been modified in the v3 patch.

Thanks
Huan