linux-kernel - Re: [linux-next, 1/1] clk: imx: imx8mm-anatop: probe only on i.MX8MM platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64488c18-d86d-490d-828f-7c82f654876e@sirena.org.uk>
Date: Mon, 19 May 2025 13:05:12 +0100
From: Mark Brown <broonie@...nel.org>
To: Dario Binacchi <dario.binacchi@...rulasolutions.com>
Cc: linux-kernel@...r.kernel.org, linux-amarula@...rulasolutions.com,
	Abel Vesa <abelvesa@...nel.org>, Fabio Estevam <festevam@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Peng Fan <peng.fan@....com>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Shawn Guo <shawnguo@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-clk@...r.kernel.org
Subject: Re: [linux-next, 1/1] clk: imx: imx8mm-anatop: probe only on i.MX8MM
 platforms

On Fri, May 16, 2025 at 03:49:27PM +0200, Dario Binacchi wrote:
> Commit 9c1e388af87c ("clk: imx: add support for i.MX8MM anatop clock
> driver") breaks boot on i.MX8M{P,N} platforms.

...

> In the imx8mp.dtsi device tree, the anatop compatible string is:
> 
> compatible = "fsl,imx8mp-anatop", "fsl,imx8mm-anatop";
> 
> So, in configurations like arm64 defconfig, where CONFIG_CLK_IMX8MP and
> CONFIG_CLK_IMX8MM as well as CONFIG_CLK_IMX8MN are enabled, the driver
> for the i.MX8MM anatop is incorrectly loaded.
> 
> The patch fixes the regression by ensuring that the i.MX8MM anatop
> driver only probes on i.MX8MM platforms.

This *works* so 

Tested-by: Mark Brown <broonie@...nel.org>

and we probably need it for existing built DTs, but shouldn't there also
be a patch to the DT source since the two blocks clearly don't seem to
be compatible.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)