linux-kernel - Re: [PATCH v2 05/26] bus: simple-pm-bus: Populate child nodes at probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCseyW1iZgZNZNqd@smile.fi.intel.com>
Date: Mon, 19 May 2025 15:06:33 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Herve Codina <herve.codina@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
	Wolfram Sang <wsa+renesas@...g-engineering.com>,
	Peter Rosin <peda@...ntia.se>,
	Derek Kiernan <derek.kiernan@....com>,
	Dragan Cvetic <dragan.cvetic@....com>,
	Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>,
	Saravana Kannan <saravanak@...gle.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Mark Brown <broonie@...nel.org>, Len Brown <lenb@...nel.org>,
	Daniel Scally <djrscally@...il.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Wolfram Sang <wsa@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
	linux-pci@...r.kernel.org, linux-spi@...r.kernel.org,
	linux-acpi@...r.kernel.org,
	Allan Nielsen <allan.nielsen@...rochip.com>,
	Horatiu Vultur <horatiu.vultur@...rochip.com>,
	Steen Hegelund <steen.hegelund@...rochip.com>,
	Luca Ceresoli <luca.ceresoli@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 05/26] bus: simple-pm-bus: Populate child nodes at
 probe

On Mon, May 19, 2025 at 01:58:18PM +0200, Herve Codina wrote:
> On Thu, 8 May 2025 17:27:52 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > On Wed, May 07, 2025 at 09:12:47AM +0200, Herve Codina wrote:

...

> > >  		if (of_property_match_string(np, "compatible", match->compatible) == 0)  
> > 
> > Side note, there is an fwnode_is_device_compatible() API for such cases. And IIRC
> > there is also OF variant of it.
> 
> fwnode_device_is_compatible() checked for all compatible string. I mean, if
> we have compatible = "foo,custom-bus", "simple-bus";
> fwnode_device_is_compatible() checking against "simple-bus" returns true.
> 
> Here, we want "simple-bus" as the first position in the compatible string.
> In other word, we want to match the more specific compatible string as
> mentioned in the comment.

I admit I'm not an expert in DT, but why is the compatibility position
dependent?

...

> > > +	if (pdev->dev.of_node)  
> > 
> > Why do you need this check? AFAICS it dups the one the call has already in it.
> 
> of_platform_populate() was called only if an OF node is present.
> I want to call of_platform_depopulate() on removal also only if an OF node
> is present.
> 
> I don't see the other call that duplicated this check.
> 
> Can you clarify?

The of_...() is already NULL-aware (AFAICS), why do you need the duplicated
check?

> > > +		of_platform_depopulate(&pdev->dev);  

-- 
With Best Regards,
Andy Shevchenko