linux-kernel - RE: [PATCH net-next v2] rtase: Use min() instead of min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb78d791abe34d9cbac30e75e7bec373@realtek.com>
Date: Mon, 19 May 2025 12:16:11 +0000
From: Justin Lai <justinlai0215@...ltek.com>
To: "kuba@...nel.org" <kuba@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "horms@...nel.org"
	<horms@...nel.org>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Larry Chiu
	<larry.chiu@...ltek.com>, Joe Damato <jdamato@...tly.com>
Subject: RE: [PATCH net-next v2] rtase: Use min() instead of min_t()

> -----Original Message-----
> From: Justin Lai <justinlai0215@...ltek.com>
> Sent: Friday, April 25, 2025 2:34 PM
> To: kuba@...nel.org
> Cc: davem@...emloft.net; edumazet@...gle.com; pabeni@...hat.com;
> andrew+netdev@...n.ch; linux-kernel@...r.kernel.org;
> netdev@...r.kernel.org; horms@...nel.org; Ping-Ke Shih
> <pkshih@...ltek.com>; Larry Chiu <larry.chiu@...ltek.com>; Justin Lai
> <justinlai0215@...ltek.com>; Joe Damato <jdamato@...tly.com>
> Subject: [PATCH net-next v2] rtase: Use min() instead of min_t()
> 
> Use min() instead of min_t() to avoid the possibility of casting to the
> wrong type.
> 
> Signed-off-by: Justin Lai <justinlai0215@...ltek.com>
> Reviewed-by: Joe Damato <jdamato@...tly.com>
> ---
> v1 -> v2:
> - Remove the Fixes tag.
> ---
>  drivers/net/ethernet/realtek/rtase/rtase_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> index 6251548d50ff..8c902eaeb5ec 100644
> --- a/drivers/net/ethernet/realtek/rtase/rtase_main.c
> +++ b/drivers/net/ethernet/realtek/rtase/rtase_main.c
> @@ -1983,7 +1983,7 @@ static u16 rtase_calc_time_mitigation(u32 time_us)
>  	u8 msb, time_count, time_unit;
>  	u16 int_miti;
> 
> -	time_us = min_t(int, time_us, RTASE_MITI_MAX_TIME);
> +	time_us = min(time_us, RTASE_MITI_MAX_TIME);
> 
>  	msb = fls(time_us);
>  	if (msb >= RTASE_MITI_COUNT_BIT_NUM) {
> @@ -2005,7 +2005,7 @@ static u16 rtase_calc_packet_num_mitigation(u16
> pkt_num)
>  	u8 msb, pkt_num_count, pkt_num_unit;
>  	u16 int_miti;
> 
> -	pkt_num = min_t(int, pkt_num, RTASE_MITI_MAX_PKT_NUM);
> +	pkt_num = min(pkt_num, RTASE_MITI_MAX_PKT_NUM);
> 
>  	if (pkt_num > 60) {
>  		pkt_num_unit = RTASE_MITI_MAX_PKT_NUM_IDX;
> --
> 2.34.1

Hi reviewers,

I apologize for the interruption, I would like to ask why this patch is
rejected on patchwork.

Justin