linux-kernel - Re: [PATCH v2 RESEND 0/6] USB: serial: ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aCsjhIbX5iT3ZALw@hovoldconsulting.com>
Date: Mon, 19 May 2025 14:26:44 +0200
From: Johan Hovold <johan@...nel.org>
To: Dominik Karol Piątkowski <dominik.karol.piatkowski@...tonmail.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 RESEND 0/6] USB: serial: ftdi_sio: Code style cleanup

On Mon, Apr 14, 2025 at 08:28:10PM +0000, Dominik Karol Piątkowski wrote:
> This series fixes spotted code style issues in ftdi_sio driver.

> Dominik Karol Piątkowski (6):
>   USB: serial: ftdi_sio: Remove space before comma
>   USB: serial: ftdi_sio: Add missing blank line after declarations
>   USB: serial: ftdi_sio: Remove superfluous space before statements
>   USB: serial: ftdi_sio: Fix indentation made with spaces
>   USB: serial: ftdi_sio: Fix misaligned block comment
>   USB: serial: ftdi_sio: Remove space before tabs

You should not be running checkpatch.pl (as you've clearly done here) on
code that's already in the kernel.

The exception is drivers/staging where patches like these are welcome so
that new contributers can practise on creating patches.

Johan