linux-kernel - Re: [PATCH] gpio: sysfs: add missing mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCsnOthU3z1jwWdb@hovoldconsulting.com>
Date: Mon, 19 May 2025 14:42:34 +0200
From: Johan Hovold <johan@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	stable@...r.kernel.org
Subject: Re: [PATCH] gpio: sysfs: add missing mutex_destroy()

On Mon, May 19, 2025 at 02:18:15PM +0200, Bartosz Golaszewski wrote:
> On Fri, May 16, 2025 at 6:58 PM Johan Hovold <johan@...nel.org> wrote:
> > On Fri, May 16, 2025 at 02:32:54PM +0200, Bartosz Golaszewski wrote:
> > > On Fri, May 16, 2025 at 1:42 PM Johan Hovold <johan@...nel.org> wrote:
> > > > On Fri, May 16, 2025 at 12:40:23PM +0200, Bartosz Golaszewski wrote:
> > > > > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > > > >
> > > > > We initialize the data->mutex in gpiod_export() but lack the
> > > > > corresponding mutex_destroy() in gpiod_unexport() causing a resource
> > > > > leak with mutex debugging enabled. Add the call right before kfreeing
> > > > > the GPIO data.
> > > >
> > > > No, there's no resource leak and it's perfectly fine not to call
> > > > mutex_destroy().
> > >
> > > No, there's no leak but with lock debugging it still warns if the
> > > mutex is locked when it's being destroyed so the change still makes
> > > sense with a modified commit message.
> > >
> > > > You can't just make shit up and then pretend to fix it...
> > >
> > > There's no need for this kind of comment. You made your point clear in
> > > the first sentence.
> >
> > Your claim that there's "a resource leak with mutex debugging enabled"
> > is is quite specific. Now I had to go check that no one had changed
> > something in ways they shouldn't have recently. But mutex_destroy()
> > still works as it always has, which you should have verified yourself
> > before sending a "fix" tagged for stable backport based on a hunch.
> 
> Yes, I admitted that the commit message was wrong. And yes, it
> sometimes happens that we get copied on crappy patches. However,
> unlike what your comment suggests, I don't go around the kernel,
> "making sh*t up" just to add a "Fixes: Johan's commit". I had this as
> part of a bigger rework I have in progress[1] (discussed previously
> here[2]) and figured that with the series growing in size, I'll at
> least get the fix upstream before v6.16-rc1.

But it is not a fix. It is based on a misunderstanding that you should
have caught yourself by just looking at the code before posting.

Sure, mutex_destroy() is an odd bird, but you still need to verify your
guesses before posting patches based on them. It's that lazy attitude
(and violation of the stable kernel policy) that I'm criticising.

Johan