[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <491d2d64-b06f-43ec-ba74-a623613beec6@linaro.org>
Date: Mon, 19 May 2025 14:58:47 +0200
From: neil.armstrong@...aro.org
To: Igor Belwon <igor.belwon@...tallysanemainliners.org>,
Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Alim Akhtar <alim.akhtar@...sung.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, linux-phy@...ts.infradead.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 2/2] phy: exynos5-usbdrd: Add support for the Exynos990
usbdrd phy
On 15/05/2025 16:43, Igor Belwon wrote:
> The Exynos990 usbdrd PHY is a combo PHY which supports USB SS, HS and
> DisplayPort outputs. This commit adds support only for UTMI+ (USB HS).
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Igor Belwon <igor.belwon@...tallysanemainliners.org>
> ---
> drivers/phy/samsung/phy-exynos5-usbdrd.c | 32 +++++++++++++++++++++++++++++
> include/linux/soc/samsung/exynos-regs-pmu.h | 3 +++
> 2 files changed, 35 insertions(+)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index 917a76d584f0856f1e445630e2cf97b3c3e46b13..dd660ebe80458a13413ca9735339b4e1095af8ea 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -2025,6 +2025,35 @@ static const struct exynos5_usbdrd_phy_drvdata exynos850_usbdrd_phy = {
> .n_regulators = ARRAY_SIZE(exynos5_regulator_names),
> };
>
> +static const struct exynos5_usbdrd_phy_tuning exynos990_tunes_utmi_postinit[] = {
> + PHY_TUNING_ENTRY_PHY(EXYNOS850_DRD_HSPPARACON,
> + (HSPPARACON_TXVREF |
> + HSPPARACON_TXPREEMPAMP | HSPPARACON_SQRX |
> + HSPPARACON_COMPDIS),
> + (FIELD_PREP_CONST(HSPPARACON_TXVREF, 7) |
> + FIELD_PREP_CONST(HSPPARACON_TXPREEMPAMP, 3) |
> + FIELD_PREP_CONST(HSPPARACON_SQRX, 5) |
> + FIELD_PREP_CONST(HSPPARACON_COMPDIS, 7))),
> + PHY_TUNING_ENTRY_LAST
> +};
> +
> +static const struct exynos5_usbdrd_phy_tuning *exynos990_tunes[PTS_MAX] = {
> + [PTS_UTMI_POSTINIT] = exynos990_tunes_utmi_postinit,
> +};
> +
> +static const struct exynos5_usbdrd_phy_drvdata exynos990_usbdrd_phy = {
> + .phy_cfg = phy_cfg_exynos850,
> + .phy_ops = &exynos850_usbdrd_phy_ops,
> + .phy_tunes = exynos990_tunes,
> + .pmu_offset_usbdrd0_phy = EXYNOS990_PHY_CTRL_USB20,
> + .clk_names = exynos5_clk_names,
> + .n_clks = ARRAY_SIZE(exynos5_clk_names),
> + .core_clk_names = exynos5_core_clk_names,
> + .n_core_clks = ARRAY_SIZE(exynos5_core_clk_names),
> + .regulator_names = exynos5_regulator_names,
> + .n_regulators = ARRAY_SIZE(exynos5_regulator_names),
> +};
> +
> static const struct exynos5_usbdrd_phy_config phy_cfg_gs101[] = {
> {
> .id = EXYNOS5_DRDPHY_UTMI,
> @@ -2228,6 +2257,9 @@ static const struct of_device_id exynos5_usbdrd_phy_of_match[] = {
> }, {
> .compatible = "samsung,exynos850-usbdrd-phy",
> .data = &exynos850_usbdrd_phy
> + }, {
> + .compatible = "samsung,exynos990-usbdrd-phy",
> + .data = &exynos990_usbdrd_phy
> },
> { },
> };
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index 1a2c0e0838f99821151661878f022f2129a0c19b..7754697e581077ec0fd60b63649728896ca145c9 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -662,6 +662,9 @@
> #define EXYNOS5433_PAD_RETENTION_UFS_OPTION (0x3268)
> #define EXYNOS5433_PAD_RETENTION_FSYSGENIO_OPTION (0x32A8)
>
> +/* For Exynos990 */
> +#define EXYNOS990_PHY_CTRL_USB20 (0x72C)
> +
> /* For Tensor GS101 */
> /* PMU ALIVE */
> #define GS101_SYSIP_DAT0 (0x810)
>
Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
Powered by blists - more mailing lists