linux-kernel - Re: [PATCH] interconnect: qcom: sm8650: enable QoS configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2328c351-1bd8-4ce8-afe5-a6df675a2738@linaro.org>
Date: Mon, 19 May 2025 15:30:01 +0200
From: neil.armstrong@...aro.org
To: Pengyu Luo <mitltlatltl@...il.com>
Cc: djakov@...nel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH] interconnect: qcom: sm8650: enable QoS configuration

On 19/05/2025 10:23, Pengyu Luo wrote:
> On Mon, 07 Apr 2025 17:16:47 +0200 Neil Armstrong <neil.armstrong@...aro.org> wrote:
>> Enable QoS configuration for master ports with predefined values
>> for priority and urgency forwarding.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> 
> [...]
> 
>> +static const struct regmap_config icc_regmap_config = {
>> +	.reg_bits = 32,
>> +	.reg_stride = 4,
>> +	.val_bits = 32,
>> +	.fast_io = true,
>> +};
> 
> [...]
> 
>>   static const struct qcom_icc_desc sm8650_mc_virt = {
>> +	.config = &icc_regmap_config,
>>   	.nodes = mc_virt_nodes,
>>   	.num_nodes = ARRAY_SIZE(mc_virt_nodes),
>>   	.bcms = mc_virt_bcms,
> 
> Hi, Neil. It seems that the config for clk_virt, mc_virt is not working
> on some devices. My device Oneplus Pad 2(pineappleP variant, mtp based,
> but without modem) shown the following.
> 
> Apr 30 01:56:16 oneplus-caihong kernel: qnoc-sm8650 interconnect-0: error -EINVAL: invalid resource (null)
> Apr 30 01:56:16 oneplus-caihong kernel: qnoc-sm8650 interconnect-1: error -EINVAL: invalid resource (null)

Right, those doesn't have registers, let me check

Thanks,
Neil

> 
> Best wishes,
> Pengyu