linux-kernel - Re: [PATCH V12 06/15] rust: macros: enable use of hyphens in module names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mNHYKXcDm6DiB=69W0w8pZ1KhqeARqqKBK_s01PPRsmQ@mail.gmail.com>
Date: Mon, 19 May 2025 16:15:28 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Danilo Krummrich <dakr@...hat.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, linux-pm@...r.kernel.org, 
	Vincent Guittot <vincent.guittot@...aro.org>, Stephen Boyd <sboyd@...nel.org>, 
	Nishanth Menon <nm@...com>, rust-for-linux@...r.kernel.org, 
	Manos Pitsidianakis <manos.pitsidianakis@...aro.org>, Alex Bennée <alex.bennee@...aro.org>, 
	Joakim Bech <joakim.bech@...aro.org>, Rob Herring <robh@...nel.org>, 
	Yury Norov <yury.norov@...il.com>, Burak Emir <bqe@...gle.com>, 
	Rasmus Villemoes <linux@...musvillemoes.dk>, Russell King <linux@...linux.org.uk>, 
	linux-clk@...r.kernel.org, Michael Turquette <mturquette@...libre.com>, 
	Andrew Ballance <andrewjballance@...il.com>, Anisse Astier <anisse@...ier.eu>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V12 06/15] rust: macros: enable use of hyphens in module names

On Mon, May 19, 2025 at 9:08 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
> +    /* Rust does not allow hyphens in identifiers, use underscore instead */

(In case you see this before you apply)

Nit: `//` for comments, also please end with a period.

Cheers,
Miguel