[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250519162733.2ef82127@bootlin.com>
Date: Mon, 19 May 2025 16:27:33 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Andrew Lunn <andrew@...n.ch>, Greg Kroah-Hartman
<gregkh@...uxfoundation.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
Danilo Krummrich <dakr@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha
Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
<kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Michael
Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, Andi
Shyti <andi.shyti@...nel.org>, Wolfram Sang
<wsa+renesas@...g-engineering.com>, Peter Rosin <peda@...ntia.se>, Derek
Kiernan <derek.kiernan@....com>, Dragan Cvetic <dragan.cvetic@....com>,
Arnd Bergmann <arnd@...db.de>, Rob Herring <robh@...nel.org>, Saravana
Kannan <saravanak@...gle.com>, Bjorn Helgaas <bhelgaas@...gle.com>, Mark
Brown <broonie@...nel.org>, Len Brown <lenb@...nel.org>, Daniel Scally
<djrscally@...il.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>, Wolfram Sang <wsa@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>, linux-kernel@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-clk@...r.kernel.org, linux-i2c@...r.kernel.org,
devicetree@...r.kernel.org, linux-pci@...r.kernel.org,
linux-spi@...r.kernel.org, linux-acpi@...r.kernel.org, Allan Nielsen
<allan.nielsen@...rochip.com>, Horatiu Vultur
<horatiu.vultur@...rochip.com>, Steen Hegelund
<steen.hegelund@...rochip.com>, Luca Ceresoli <luca.ceresoli@...tlin.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 06/26] driver core: fw_devlink: Introduce
fw_devlink_set_device()
Hi Andy,
On Wed, 7 May 2025 18:02:40 +0300
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> On Wed, May 07, 2025 at 09:12:48AM +0200, Herve Codina wrote:
> > Setting fwnode->dev is specific to fw_devlink.
> >
> > In order to avoid having a direct 'fwnode->dev = dev;' in several
> > place in the kernel, introduce fw_devlink_set_device() helper to perform
> > this operation.
>
> Makes sense, can you also mark that field as __private? So sparse can catch
> the abusers up.
>
I didn't know about __private tag and related ACCESS_PRIVATE().
Indeed, It makes perfect sense.
I will add it in next iteration.
Thanks for pointing out.
Best regards,
Hervé
Powered by blists - more mailing lists