linux-kernel - Re: [PATCH v3] dt-bindings: mmc: ti-omap2420-mmc: convert text based binding to json schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0ae042a-7c38-4e9d-9664-157afd861c3c@kernel.org>
Date: Tue, 20 May 2025 16:09:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charan Pedumuru <charan.pedumuru@...il.com>,
 Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Tony Lindgren <tony@...mide.com>
Cc: linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] dt-bindings: mmc: ti-omap2420-mmc: convert text based
 binding to json schema

On 20/05/2025 15:12, Charan Pedumuru wrote:
> Convert TI MMC host controller binding to YAML format.
> Changes during Conversion:
> - Add new properties 'dma', 'dma-names' under required.

Why?

> - Define two separate phandles for 'dmas' in the examples.
> - Include appropriate header file for interrupts and use
>   it in the examples.

Examples are not the binding, so you can drop last two items.

> 
> Signed-off-by: Charan Pedumuru <charan.pedumuru@...il.com>
> ---
> Changes in v3:


...

> +  dmas:
> +    maxItems: 2
> +
> +  dma-names:
> +    items:
> +      - const: tx
> +      - const: rx
> +
> +  ti,hwmods:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    description:
> +      List of hwmod names (ascii strings), that comes from the OMAP
> +      HW documentation, attached to a device. Must contain at least
> +      one hwmod.

Description does not match the property. It is not a list and where the
hwmod below:

> +    pattern: "^msdi[0-9]+$"

I see msdi - is it something different?

There was no such description in original binding, so maybe you are
changing something but anyway it should be correct.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - dmas
> +  - dma-names
> +  - ti,hwmods
Best regards,
Krzysztof