linux-kernel - Re: [PATCH v6 11/16] PCI/AER: Check log level once and remember it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250520144624.GA1299876@bhelgaas>
Date: Tue, 20 May 2025 09:46:24 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Weinan Liu <wnliu@...gle.com>
Cc: Jonathan.Cameron@...wei.com, anilagrawal@...a.com,
	ben.fuller@...cle.com, bhelgaas@...gle.com, dave.jiang@...el.com,
	drewwalton@...rosoft.com, ilpo.jarvinen@...ux.intel.com,
	kaihengf@...dia.com, karolina.stolarek@...cle.com,
	kbusch@...nel.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	lukas@...ner.de, mahesh@...ux.ibm.com, martin.petersen@...cle.com,
	oohall@...il.com, pandoh@...gle.com, paulmck@...nel.org,
	rrichter@....com, sargun@...a.com,
	sathyanarayanan.kuppuswamy@...ux.intel.com, shiju.jose@...wei.com,
	terry.bowman@....com, tony.luck@...el.com
Subject: Re: [PATCH v6 11/16] PCI/AER: Check log level once and remember it

On Mon, May 19, 2025 at 11:17:28PM +0000, Weinan Liu wrote:
> > diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> > index 315bf2bfd570..34af0ea45c0d 100644
> > --- a/drivers/pci/pcie/dpc.c
> > +++ b/drivers/pci/pcie/dpc.c
> > @@ -252,6 +252,7 @@ static int dpc_get_aer_uncorrect_severity(struct pci_dev *dev,
> >   else
> >   info->severity = AER_NONFATAL;
> >
> > + info->level = KERN_WARNING;
> >  return 1;
> > }
> 
> I think the print level should be KERN_ERR for uncorrectable errors.

Yes, thank you, fixed!  dpc_get_aer_uncorrect_severity() always sets
info->severity to AER_FATAL or AER_NONFATAL, and aer_print_error()
only uses KERN_WARNING for AER_CORRECTABLE.